Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 2599643004: Remove unwanted declaration of storage for NeedsAdjustAndMark<>. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/GarbageCollected.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp
diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
index 1310bac479cbd23cccbd3a017c0696de49d5704d..fc3d4adf304aa95229f460c7d9d406c4717e528a 100644
--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp
+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
@@ -4843,16 +4843,22 @@ TEST(HeapTest, GCParkingTimeout) {
TEST(HeapTest, NeedsAdjustAndMark) {
// class Mixin : public GarbageCollectedMixin {};
- EXPECT_TRUE(NeedsAdjustAndMark<Mixin>::value);
- EXPECT_TRUE(NeedsAdjustAndMark<const Mixin>::value);
+ static_assert(NeedsAdjustAndMark<Mixin>::value,
+ "A Mixin pointer needs adjustment");
+ static_assert(NeedsAdjustAndMark<Mixin>::value,
+ "A const Mixin pointer needs adjustment");
// class SimpleObject : public GarbageCollected<SimpleObject> {};
- EXPECT_FALSE(NeedsAdjustAndMark<SimpleObject>::value);
- EXPECT_FALSE(NeedsAdjustAndMark<const SimpleObject>::value);
+ static_assert(!NeedsAdjustAndMark<SimpleObject>::value,
+ "A SimpleObject pointer does not need adjustment");
+ static_assert(!NeedsAdjustAndMark<const SimpleObject>::value,
+ "A const SimpleObject pointer does not need adjustment");
// class UseMixin : public SimpleObject, public Mixin {};
- EXPECT_FALSE(NeedsAdjustAndMark<UseMixin>::value);
- EXPECT_FALSE(NeedsAdjustAndMark<const UseMixin>::value);
+ static_assert(!NeedsAdjustAndMark<UseMixin>::value,
+ "A UseMixin pointer does not need adjustment");
+ static_assert(!NeedsAdjustAndMark<const UseMixin>::value,
+ "A const UseMixin pointer does not need adjustment");
}
template <typename Set>
« no previous file with comments | « third_party/WebKit/Source/platform/heap/GarbageCollected.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698