Fix for crbug.com/675863 - don't clobber PAUSE state.

Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

Original change this was cherry picked from:
Review-Url: https://codereview.chromium.org/2598573003
Cr-Commit-Position: refs/heads/master@{#440212}
(manually cherry picked from commit ff7cfc31cc358e47ed3b311a97fb6f9a728507dc)

BUG=675863
R=dewittj@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/2dddbcafe16533b7f638a8a0fa8155267b3cbb52

[Pete Williamson, 2016-12-22 00:09:42]

petewil@chromium.org changed reviewers:
+ dewittj@chromium.org

[Pete Williamson, 2016-12-22 00:09:42]

This is just landing the patch we already checked into M57 onto M56.  I left out
the unit test to make the change smaller, but the unit test is in M57.

[dewittj, 2016-12-22 00:14:07]

I think including the unit test is important; the build will break if something
goes wrong with it.  Can you please just include the entire patch?  Further
merges will be confusing if they include parts of changes.

Also since Drover copies the commit description it might be useful to mimic that
style.  At least include the cherry-picked-from section.  See e.g.
https://chromium.googlesource.com/chromium/src/+/29592a2449a6c9b745fbe208ba34...
for example.

[Pete Williamson, 2016-12-22 00:25:12]

Description was changed from

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

Git drover failed, manually updating the one important line.

BUG=675863
==========

to

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

Review-Url: https://codereview.chromium.org/2599593002
(manually cherry picked from commit ff7cfc31cc358e47ed3b311a97fb6f9a728507dc)

Original change this was cherry picked from:
Review-Url: https://codereview.chromium.org/2598573003
Cr-Commit-Position: refs/heads/master@{#440212}

BUG=675863
==========

[Pete Williamson, 2016-12-22 00:36:54]

Added unit test back in.

See if you like the format for the description, I couldn't exactly match the one
I saw, since I don't have the final commit location yet.

[dewittj, 2016-12-22 00:42:41]

I think you only need to include the first block, the rest is added by rietveld:

Review-Url: (original review URL)
Cr-Commit-Position: (original commit position)
(cherry picked from commit (original hash))

otherwise lgtm

[Pete Williamson, 2016-12-22 00:46:43]

Description was changed from

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

Review-Url: https://codereview.chromium.org/2599593002
(manually cherry picked from commit ff7cfc31cc358e47ed3b311a97fb6f9a728507dc)

Original change this was cherry picked from:
Review-Url: https://codereview.chromium.org/2598573003
Cr-Commit-Position: refs/heads/master@{#440212}

BUG=675863
==========

to

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

Original change this was cherry picked from:
Review-Url: https://codereview.chromium.org/2598573003
Cr-Commit-Position: refs/heads/master@{#440212}
(manually cherry picked from commit ff7cfc31cc358e47ed3b311a97fb6f9a728507dc)

BUG=675863
==========

[Pete Williamson, 2016-12-22 00:50:51]

Description was changed from

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

Original change this was cherry picked from:
Review-Url: https://codereview.chromium.org/2598573003
Cr-Commit-Position: refs/heads/master@{#440212}
(manually cherry picked from commit ff7cfc31cc358e47ed3b311a97fb6f9a728507dc)

BUG=675863
==========

to

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

Original change this was cherry picked from:
Review-Url: https://codereview.chromium.org/2598573003
Cr-Commit-Position: refs/heads/master@{#440212}
(manually cherry picked from commit ff7cfc31cc358e47ed3b311a97fb6f9a728507dc)

BUG=675863
R=dewittj@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/2dddbcafe16533b7f638a8a0fa81...
==========

[Pete Williamson, 2016-12-22 00:50:53]

Committed patchset #2 (id:20001) manually as
2dddbcafe16533b7f638a8a0fa8155267b3cbb52 (presubmit successful).