Fix for crbug.com/675863 - don't clobber PAUSE state.

Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

BUG=675863
Committed: https://crrev.com/ff7cfc31cc358e47ed3b311a97fb6f9a728507dc
Cr-Commit-Position: refs/heads/master@{#440212}

[Pete Williamson, 2016-12-21 19:11:15]

petewil@chromium.org changed reviewers:
+ dewittj@chromium.org, dougarnett@chromium.org

[dewittj, 2016-12-21 19:13:00]

lg, can you write a test?

[dougarnett, 2016-12-21 19:25:21]

https://codereview.chromium.org/2598573003/diff/1/components/offline_pages/co...
File components/offline_pages/core/background/save_page_request.cc (right):

https://codereview.chromium.org/2598573003/diff/1/components/offline_pages/co...
components/offline_pages/core/background/save_page_request.cc:85: if (state_ ==
RequestState::OFFLINING)
Please update the method comment in .h to be accurate too (to mention state
change if OFFLINING and not lie about other stuff).

[Pete Williamson, 2016-12-21 19:30:55]

Test added per DewittJ, comment updated per DougArnett

https://codereview.chromium.org/2598573003/diff/1/components/offline_pages/co...
File components/offline_pages/core/background/save_page_request.cc (right):

https://codereview.chromium.org/2598573003/diff/1/components/offline_pages/co...
components/offline_pages/core/background/save_page_request.cc:85: if (state_ ==
RequestState::OFFLINING)
On 2016/12/21 19:25:21, dougarnett wrote:
> Please update the method comment in .h to be accurate too (to mention state
> change if OFFLINING and not lie about other stuff).

Done.

[Pete Williamson, 2016-12-21 19:31:02]

The CQ bit was checked by petewil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 19:32:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-12-21 19:33:27]

lgtm

[dougarnett, 2016-12-21 19:33:39]

lgtm

[commit-bot: I haz the power, 2016-12-21 20:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 20:53:38]

Dry run: This issue passed the CQ dry run.

[Pete Williamson, 2016-12-21 20:59:32]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:00:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:14:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482353972528420,
"parent_rev": "2b873cc59e6d28e19109fff56c248f99b1782ce2", "commit_rev":
"0f10a961cb8c145c9578a35f3b37499aeb578f30"}

[commit-bot: I haz the power, 2016-12-21 21:14:32]

Description was changed from

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

BUG=675863
==========

to

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

BUG=675863

Review-Url: https://codereview.chromium.org/2598573003
==========

[commit-bot: I haz the power, 2016-12-21 21:14:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 21:19:21]

Description was changed from

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

BUG=675863

Review-Url: https://codereview.chromium.org/2598573003
==========

to

==========
Fix for crbug.com/675863 - don't clobber PAUSE state.

When making a page available for offlining, we were clobbering the pause
state.  We now check to only change the state to AVAILABLE if it was
previously OFFLINING, allowing the PAUSE state to remain unchanged.

BUG=675863

Committed: https://crrev.com/ff7cfc31cc358e47ed3b311a97fb6f9a728507dc
Cr-Commit-Position: refs/heads/master@{#440212}
==========

[commit-bot: I haz the power, 2016-12-21 21:19:22]

Patchset 2 (id:??) landed as
https://crrev.com/ff7cfc31cc358e47ed3b311a97fb6f9a728507dc
Cr-Commit-Position: refs/heads/master@{#440212}