Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 2599573002: [SPInvalidation] Update paint properties when full screen status changes (Closed)
Patch Set: [SPInvalidation] Update paint properties when full screen status changes Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 16 matching lines...) Expand all
27 * 27 *
28 */ 28 */
29 29
30 #include "core/dom/Fullscreen.h" 30 #include "core/dom/Fullscreen.h"
31 31
32 #include "bindings/core/v8/ConditionalFeatures.h" 32 #include "bindings/core/v8/ConditionalFeatures.h"
33 #include "core/dom/Document.h" 33 #include "core/dom/Document.h"
34 #include "core/dom/ElementTraversal.h" 34 #include "core/dom/ElementTraversal.h"
35 #include "core/dom/StyleEngine.h" 35 #include "core/dom/StyleEngine.h"
36 #include "core/events/Event.h" 36 #include "core/events/Event.h"
37 #include "core/frame/FrameView.h"
37 #include "core/frame/HostsUsingFeatures.h" 38 #include "core/frame/HostsUsingFeatures.h"
38 #include "core/frame/LocalFrame.h" 39 #include "core/frame/LocalFrame.h"
39 #include "core/frame/Settings.h" 40 #include "core/frame/Settings.h"
40 #include "core/frame/UseCounter.h" 41 #include "core/frame/UseCounter.h"
41 #include "core/html/HTMLIFrameElement.h" 42 #include "core/html/HTMLIFrameElement.h"
42 #include "core/input/EventHandler.h" 43 #include "core/input/EventHandler.h"
43 #include "core/inspector/ConsoleMessage.h" 44 #include "core/inspector/ConsoleMessage.h"
44 #include "core/layout/LayoutBlockFlow.h" 45 #include "core/layout/LayoutBlockFlow.h"
45 #include "core/layout/LayoutFullScreen.h" 46 #include "core/layout/LayoutFullScreen.h"
46 #include "core/layout/api/LayoutFullScreenItem.h" 47 #include "core/layout/api/LayoutFullScreenItem.h"
(...skipping 840 matching lines...) Expand 10 before | Expand all | Expand 10 after
887 LayoutFullScreen::wrapLayoutObject( 888 LayoutFullScreen::wrapLayoutObject(
888 layoutObject, layoutObject ? layoutObject->parent() : 0, document()); 889 layoutObject, layoutObject ? layoutObject->parent() : 0, document());
889 } 890 }
890 } 891 }
891 892
892 if (LocalFrame* frame = document()->frame()) { 893 if (LocalFrame* frame = document()->frame()) {
893 // TODO(foolip): Synchronize hover state changes with animation frames. 894 // TODO(foolip): Synchronize hover state changes with animation frames.
894 // https://crbug.com/668758 895 // https://crbug.com/668758
895 frame->eventHandler().scheduleHoverStateUpdate(); 896 frame->eventHandler().scheduleHoverStateUpdate();
896 frame->chromeClient().fullscreenElementChanged(fromElement, toElement); 897 frame->chromeClient().fullscreenElementChanged(fromElement, toElement);
898
899 if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() &&
900 !RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
901 // Fullscreen status affects scroll paint properties through
902 // FrameView::userInputScrollable().
903 if (FrameView* frameView = frame->view())
904 frame->view()->setNeedsPaintPropertyUpdate();
pdr. 2016/12/22 00:37:16 nit: use the local variable: if (FrameView* frameV
Xianzhu 2016/12/22 00:45:29 Done.
905 }
897 } 906 }
898 907
899 // TODO(foolip): This should not call updateStyleAndLayoutTree. 908 // TODO(foolip): This should not call updateStyleAndLayoutTree.
900 document()->updateStyleAndLayoutTree(); 909 document()->updateStyleAndLayoutTree();
901 } 910 }
902 911
903 DEFINE_TRACE(Fullscreen) { 912 DEFINE_TRACE(Fullscreen) {
904 visitor->trace(m_pendingRequests); 913 visitor->trace(m_pendingRequests);
905 visitor->trace(m_fullscreenElementStack); 914 visitor->trace(m_fullscreenElementStack);
906 Supplement<Document>::trace(visitor); 915 Supplement<Document>::trace(visitor);
907 ContextLifecycleObserver::trace(visitor); 916 ContextLifecycleObserver::trace(visitor);
908 } 917 }
909 918
910 } // namespace blink 919 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698