Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 259943002: Revert "Revert 266297 "1. Handle the case of empty embedder_extension_id..."" (Closed)

Created:
6 years, 8 months ago by Dan Beam
Modified:
6 years, 7 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Michael van Ouwerkerk, extensions-reviews_chromium.org, Xi Han
Visibility:
Public.

Description

Revert "Revert 266297 "1. Handle the case of empty embedder_extension_id..."" Retry r266297 with static initializer fix. This reverts commit 9ca50c9f36065f24fb1e39dbbf6f09b52eac285e. BUG=351824 TBR=rmsousa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266523

Patch Set 1 : static intializer fix #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -3328 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 6 chunks +18 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webview/webview_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/guest_view/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/guest_view/ad_view/ad_view_constants.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guest_view/ad_view/ad_view_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/guest_view/ad_view/ad_view_guest.h View 3 chunks +7 lines, -12 lines 0 comments Download
A + chrome/browser/guest_view/ad_view/ad_view_guest.cc View 4 chunks +9 lines, -26 lines 1 comment Download
A chrome/browser/guest_view/guest_view.h View 1 chunk +41 lines, -0 lines 1 comment Download
A + chrome/browser/guest_view/guest_view_base.h View 8 chunks +36 lines, -43 lines 1 comment Download
A + chrome/browser/guest_view/guest_view_base.cc View 8 chunks +68 lines, -86 lines 0 comments Download
A + chrome/browser/guest_view/guest_view_constants.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guest_view/guest_view_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/guest_view/web_view/context_menu_content_type_web_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/guest_view/web_view/javascript_dialog_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guest_view/web_view/javascript_dialog_helper.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/guest_view/web_view/plugin_permission_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guest_view/web_view/plugin_permission_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_constants.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_find_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_find_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_guest.h View 3 chunks +10 lines, -14 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_guest.cc View 19 chunks +39 lines, -54 lines 0 comments Download
A + chrome/browser/guest_view/web_view/web_view_permission_types.h View 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/guestview/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/guestview/adview/adview_constants.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/guestview/adview/adview_constants.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/guestview/adview/adview_guest.h View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/guestview/adview/adview_guest.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/guestview/guestview.h View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/guestview/guestview.cc View 1 chunk +0 lines, -223 lines 0 comments Download
D chrome/browser/guestview/guestview_constants.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/guestview/guestview_constants.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/guestview/webview/context_menu_content_type_webview.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/guestview/webview/context_menu_content_type_webview.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/guestview/webview/javascript_dialog_helper.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/guestview/webview/javascript_dialog_helper.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/browser/guestview/webview/plugin_permission_helper.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/guestview/webview/plugin_permission_helper.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/guestview/webview/webview_constants.h View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/guestview/webview/webview_constants.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/guestview/webview/webview_find_helper.h View 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/browser/guestview/webview/webview_find_helper.cc View 1 chunk +0 lines, -279 lines 0 comments Download
D chrome/browser/guestview/webview/webview_guest.h View 1 chunk +0 lines, -327 lines 0 comments Download
D chrome/browser/guestview/webview/webview_guest.cc View 1 chunk +0 lines, -1038 lines 0 comments Download
D chrome/browser/guestview/webview/webview_permission_types.h View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +23 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dan Beam
not sure if there is a way to try sizes... I'll CQ this to see ...
6 years, 8 months ago (2014-04-26 03:31:53 UTC) #1
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 8 months ago (2014-04-26 03:32:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/259943002/20001
6 years, 8 months ago (2014-04-26 03:34:02 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 05:23:23 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 05:23:23 UTC) #5
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 7 months ago (2014-04-28 08:55:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/259943002/20001
6 years, 7 months ago (2014-04-28 08:57:06 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 12:30:16 UTC) #8
Message was sent while issue was closed. 
Change committed as 266523

Powered by Google App Engine
This is Rietveld 408576698