Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3057)

Unified Diff: chrome/browser/guestview/adview/adview_guest.h

Issue 259943002: Revert "Revert 266297 "1. Handle the case of empty embedder_extension_id..."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: static intializer fix Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guestview/adview/adview_guest.h
diff --git a/chrome/browser/guestview/adview/adview_guest.h b/chrome/browser/guestview/adview/adview_guest.h
deleted file mode 100644
index aaefe00e3644e169025c63f031e977dd3cdd695f..0000000000000000000000000000000000000000
--- a/chrome/browser/guestview/adview/adview_guest.h
+++ /dev/null
@@ -1,54 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_GUESTVIEW_ADVIEW_ADVIEW_GUEST_H_
-#define CHROME_BROWSER_GUESTVIEW_ADVIEW_ADVIEW_GUEST_H_
-
-#include "base/values.h"
-#include "chrome/browser/guestview/guestview.h"
-#include "content/public/browser/web_contents_observer.h"
-
-// An AdViewGuest is a WebContentsObserver on the guest WebContents of a
-// <adview> tag. It provides the browser-side implementation of the <adview>
-// API and manages the lifetime of <adview> extension events. AdViewGuest is
-// created on attachment. When a guest WebContents is associated with
-// a particular embedder WebContents, we call this "attachment".
-// TODO(fsamuel): There might be an opportunity here to refactor and reuse code
-// between AdViewGuest and WebViewGuest.
-class AdViewGuest : public GuestView,
- public content::WebContentsObserver {
- public:
- AdViewGuest(content::WebContents* guest_web_contents,
- const std::string& extension_id);
-
- static AdViewGuest* From(int embedder_process_id, int instance_id);
-
- // GuestView implementation.
- virtual GuestView::Type GetViewType() const OVERRIDE;
- virtual WebViewGuest* AsWebView() OVERRIDE;
- virtual AdViewGuest* AsAdView() OVERRIDE;
-
- private:
- virtual ~AdViewGuest();
-
- virtual void DidCommitProvisionalLoadForFrame(
- int64 frame_id,
- const base::string16& frame_unique_name,
- bool is_main_frame,
- const GURL& url,
- content::PageTransition transition_type,
- content::RenderViewHost* render_view_host) OVERRIDE;
- virtual void DidFailProvisionalLoad(
- int64 frame_id,
- const base::string16& frame_unique_name,
- bool is_main_frame,
- const GURL& validated_url,
- int error_code,
- const base::string16& error_description,
- content::RenderViewHost* render_view_host) OVERRIDE;
-
- DISALLOW_COPY_AND_ASSIGN(AdViewGuest);
-};
-
-#endif // CHROME_BROWSER_GUESTVIEW_ADVIEW_ADVIEW_GUEST_H_

Powered by Google App Engine
This is Rietveld 408576698