Revert "Revert 266297 "1. Handle the case of empty embedder_extension_id...""

chrome/browser/guest_view/ad_view/ad_view_guest.cc

Index: chrome/browser/guest_view/ad_view/ad_view_guest.cc
diff --git a/chrome/browser/guestview/adview/adview_guest.cc b/chrome/browser/guest_view/ad_view/ad_view_guest.cc
similarity index 63%
rename from chrome/browser/guestview/adview/adview_guest.cc
rename to chrome/browser/guest_view/ad_view/ad_view_guest.cc
index 6b0de6fbca74d5e556d2d2ccca5982b2566817c3..b09b8df377d9434a95c6d5cfc4367de167927e15 100644
--- a/chrome/browser/guestview/adview/adview_guest.cc
+++ b/chrome/browser/guest_view/ad_view/ad_view_guest.cc
@@ -1,12 +1,12 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/guestview/adview/adview_guest.h"
+#include "chrome/browser/guest_view/ad_view/ad_view_guest.h"
 
 #include "base/strings/string_util.h"
-#include "chrome/browser/guestview/adview/adview_constants.h"
-#include "chrome/browser/guestview/guestview_constants.h"
+#include "chrome/browser/guest_view/ad_view/ad_view_constants.h"
+#include "chrome/browser/guest_view/guest_view_constants.h"
 #include "content/public/browser/web_contents.h"
 #include "net/base/net_errors.h"
 
@@ -14,30 +14,12 @@ using content::WebContents;
 
 AdViewGuest::AdViewGuest(WebContents* guest_web_contents,
                          const std::string& extension_id)
-    : GuestView(guest_web_contents, extension_id),
+    : GuestView<AdViewGuest>(guest_web_contents, extension_id),
       WebContentsObserver(guest_web_contents) {
 }
 
 // static
-AdViewGuest* AdViewGuest::From(int embedder_process_id,
-                               int guest_instance_id) {
-  GuestView* guest = GuestView::From(embedder_process_id, guest_instance_id);
-  if (!guest)
-    return NULL;
-  return guest->AsAdView();
-}
-
-GuestView::Type AdViewGuest::GetViewType() const {
-  return GuestView::ADVIEW;
-}
-
-WebViewGuest* AdViewGuest::AsWebView() {
-  return NULL;
-}
-
-AdViewGuest* AdViewGuest::AsAdView() {
-  return this;
-}
+const char AdViewGuest::Type[] = "adview";

[Dan Beam, 2014/04/26 03:31:54]

^ this is a potential fix

 
 AdViewGuest::~AdViewGuest() {
 }
@@ -52,7 +34,8 @@ void AdViewGuest::DidCommitProvisionalLoadForFrame(
   scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
   args->SetString(guestview::kUrl, url.spec());
   args->SetBoolean(guestview::kIsTopLevel, is_main_frame);
-  DispatchEvent(new GuestView::Event(adview::kEventLoadCommit, args.Pass()));
+  DispatchEvent(
+      new GuestViewBase::Event(adview::kEventLoadCommit, args.Pass()));
 }
 
 void AdViewGuest::DidFailProvisionalLoad(
@@ -71,5 +54,5 @@ void AdViewGuest::DidFailProvisionalLoad(
   args->SetBoolean(guestview::kIsTopLevel, is_main_frame);
   args->SetString(guestview::kUrl, validated_url.spec());
   args->SetString(guestview::kReason, error_type);
-  DispatchEvent(new GuestView::Event(adview::kEventLoadAbort, args.Pass()));
+  DispatchEvent(new GuestViewBase::Event(adview::kEventLoadAbort, args.Pass()));
 }