Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2599313002: Create headerHeightForTab in TabHeadersDelegate. (Closed)
Patch Set: only fullscreencontroller and sideswipecontroller Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index dac801e1c4f1db0c0e1a3326758002f4ff205054..9b6bd049b4bc1d8d3b3b14eda888dc0953ff7c0a 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1763,8 +1763,9 @@ void AddNetworkClientFactoryOnIOThread(
// Display the action sheet with the arrow pointing at the top center of the
// web contents.
CGFloat xOrigin = CGRectGetMidX(self.webState->GetView().frame);
- CGFloat yOrigin = CGRectGetMinY(self.webState->GetView().frame) +
- [[self fullScreenControllerDelegate] headerHeight];
+ CGFloat yOrigin =
+ CGRectGetMinY(self.webState->GetView().frame) +
+ [[self fullScreenControllerDelegate] headerHeightForTab:self];
[resubmitDataController_
presentActionSheetFromRect:CGRectMake(xOrigin, yOrigin, 1, 1)
inView:self.webState->GetView()];
@@ -2197,7 +2198,8 @@ void AddNetworkClientFactoryOnIOThread(
}
- (CGFloat)headerHeightForWebController:(CRWWebController*)webController {
- return [fullScreenControllerDelegate_ headerHeight];
+ DCHECK(webController == [self webController]);
+ return [fullScreenControllerDelegate_ headerHeightForTab:self];
}
- (void)webControllerDidUpdateSSLStatusForCurrentNavigationItem:

Powered by Google App Engine
This is Rietveld 408576698