Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm

Issue 2599313002: Create headerHeightForTab in TabHeadersDelegate. (Closed)
Patch Set: only fullscreencontroller and sideswipecontroller Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.mm » ('j') | ios/chrome/browser/ui/fullscreen_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm
diff --git a/ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm b/ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm
index 8ff35086c3e364196d02300c1fc2810be77f88cb..044e5bd285891c1d695aa5c29f8e1d614a820080 100644
--- a/ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm
+++ b/ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm
@@ -195,9 +195,9 @@
snapshotToCache = snapshot;
} else {
// Crops the bottom of the fullscreen snapshot.
- CGRect cropRect =
- CGRectMake(0, [[_tab fullScreenControllerDelegate] headerHeight],
- [snapshot size].width, [snapshot size].height);
+ CGRect cropRect = CGRectMake(
+ 0, [[_tab fullScreenControllerDelegate] headerHeightForTab:_tab],
+ [snapshot size].width, [snapshot size].height);
snapshotToCache = CropImage(snapshot, cropRect);
}
[_snapshotManager setImage:snapshotToCache withSessionID:sessionID];
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.mm » ('j') | ios/chrome/browser/ui/fullscreen_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698