Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: ios/chrome/browser/ui/fullscreen_controller.h

Issue 2599313002: Create headerHeightForTab in TabHeadersDelegate. (Closed)
Patch Set: only fullscreencontroller and sideswipecontroller Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/browser_view_controller.mm ('k') | ios/chrome/browser/ui/fullscreen_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/fullscreen_controller.h
diff --git a/ios/chrome/browser/ui/fullscreen_controller.h b/ios/chrome/browser/ui/fullscreen_controller.h
index 14dbd25c6d5fa42a6f583bd6eadb50a25e4878b2..f841ca4087af6e0c08a459fcbe8346484d41e489 100644
--- a/ios/chrome/browser/ui/fullscreen_controller.h
+++ b/ios/chrome/browser/ui/fullscreen_controller.h
@@ -17,6 +17,7 @@ const NSTimeInterval kToolbarAnimationDuration = 0.3;
@class CRWWebViewScrollViewProxy;
@class FullScreenController;
+@class Tab;
namespace web {
class NavigationManager;
@@ -49,10 +50,15 @@ extern NSString* const kSetupForTestingWillCloseAllTabsNotification;
changeTopContentPadding:(BOOL)changeTopContentPadding
scrollingToOffset:(CGFloat)contentOffset;
-// Called to retrieve the current height of the header. Only called from
+// Called to retrieve the height of the header view for the tab model's current
+// tab. Only called from -setHeaderVisible:, so that method needs to be
+// explicitly called when the height changes.
+- (CGFloat)headerHeightForCurrentTab;
+
+// Called to retrieve the height of the header view for |tab|. Only called from
// -setHeaderVisible:, so that method needs to be explicitly called when the
// height changes.
-- (CGFloat)headerHeight;
+- (CGFloat)headerHeightForTab:(Tab*)tab;
noyau (Ping after 24h) 2017/01/09 15:09:31 This method should not be in this protocol, it is
Olivier 2017/01/09 17:23:18 Right. The delegate was called from other places.
// Tests if the session ID matches the current tab.
- (BOOL)isTabWithIDCurrent:(NSString*)sessionID;
« no previous file with comments | « ios/chrome/browser/ui/browser_view_controller.mm ('k') | ios/chrome/browser/ui/fullscreen_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698