Add transform and background not opaque as main thread scrolling reasons

Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/1bbdf620f45d6d5753ddcad660af175e30e79e13
Cr-Commit-Position: refs/heads/master@{#441308}

[yigu, 2016-12-22 19:45:54]

Description was changed from

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
==========

to

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[yigu, 2016-12-22 19:45:55]

Description was changed from

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[yigu, 2016-12-22 19:50:37]

yigu@chromium.org changed reviewers:
+ bokan@chromium.org, jwd@chromium.org, weiliangc@chromium.org

[yigu, 2016-12-22 19:50:38]

Hi! Just added two more style related main thread scrolling reasons for UMA
purpose. PTAL.
Thanks!

[jwd, 2017-01-02 16:59:12]

histograms LGTM

[bokan, 2017-01-03 16:31:17]

https://codereview.chromium.org/2599043003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp (right):

https://codereview.chromium.org/2599043003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp:1035:
TEST_F(ScrollingCoordinatorTest, StyleRelatedMainThreadScrollingReasonTest) {
Make styleRelatedMainThreadScrollingReasonTest a class and make each of these
styles a separate TEST_F. For e.g. see CompositedSelectionBoundsTest in
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/tests/WebF...

[yigu, 2017-01-03 21:49:58]

Hi David,
I've made the styleRelatedTest a class as you suggested. PTAL.
Thanks!
Yi

https://codereview.chromium.org/2599043003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp (right):

https://codereview.chromium.org/2599043003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp:1035:
TEST_F(ScrollingCoordinatorTest, StyleRelatedMainThreadScrollingReasonTest) {
On 2017/01/03 16:31:17, bokan wrote:
> Make styleRelatedMainThreadScrollingReasonTest a class and make each of these
> styles a separate TEST_F. For e.g. see CompositedSelectionBoundsTest in
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/tests/WebF...

Done.

[bokan, 2017-01-03 21:52:09]

lgtm

[yigu, 2017-01-03 22:24:57]

Description was changed from

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[yigu, 2017-01-03 22:24:57]

yigu@chromium.org changed reviewers:
+ ajuma@chromium.org
- weiliangc@chromium.org

[ajuma, 2017-01-03 22:31:06]

https://codereview.chromium.org/2599043003/diff/20001/cc/input/main_thread_sc...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/2599043003/diff/20001/cc/input/main_thread_sc...
cc/input/main_thread_scrolling_reason.h:48: kMainThreadScrollingReasonCount =
20,
Should this be 19? (since the flag with the largest value is 1 << 18)

[yigu, 2017-01-03 22:44:15]

https://codereview.chromium.org/2599043003/diff/20001/cc/input/main_thread_sc...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/2599043003/diff/20001/cc/input/main_thread_sc...
cc/input/main_thread_scrolling_reason.h:48: kMainThreadScrollingReasonCount =
20,
On 2017/01/03 22:31:05, ajuma wrote:
> Should this be 19? (since the flag with the largest value is 1 << 18)

It should be 19 + 1. I read about the reason somewhere. Will try to find it n
and keep you updated.

[yigu, 2017-01-03 23:09:14]

HI Ali,
PTAL.

https://codereview.chromium.org/2599043003/diff/20001/cc/input/main_thread_sc...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/2599043003/diff/20001/cc/input/main_thread_sc...
cc/input/main_thread_scrolling_reason.h:48: kMainThreadScrollingReasonCount =
20,
On 2017/01/03 22:44:15, yigu wrote:
> On 2017/01/03 22:31:05, ajuma wrote:
> > Should this be 19? (since the flag with the largest value is 1 << 18)
> 
> It should be 19 + 1. I read about the reason somewhere. Will try to find it n
> and keep you updated.

See https://codereview.chromium.org/2360113003 for the discussion.

[ajuma, 2017-01-04 00:28:10]

lgtm

https://codereview.chromium.org/2599043003/diff/20001/cc/input/main_thread_sc...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/2599043003/diff/20001/cc/input/main_thread_sc...
cc/input/main_thread_scrolling_reason.h:48: kMainThreadScrollingReasonCount =
20,
On 2017/01/03 23:09:14, yigu wrote:
> On 2017/01/03 22:44:15, yigu wrote:
> > On 2017/01/03 22:31:05, ajuma wrote:
> > > Should this be 19? (since the flag with the largest value is 1 << 18)
> > 
> > It should be 19 + 1. I read about the reason somewhere. Will try to find it
n
> > and keep you updated.
> 
> See https://codereview.chromium.org/2360113003 for the discussion. 

Thanks for looking into this.

[yigu, 2017-01-04 01:53:21]

The CQ bit was checked by yigu@chromium.org

[yigu, 2017-01-04 01:53:21]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2599043003/#ps20001
(title: "Make styleRelatedMainThreadScrollingReasonTest a class")

[commit-bot: I haz the power, 2017-01-04 01:53:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 03:20:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483494801235190,
"parent_rev": "73ffedbd15aa9a79d660e796cfa553d1f04c84d1", "commit_rev":
"047ba6496b5298e533ff1621e292ef47d8e605c3"}

[commit-bot: I haz the power, 2017-01-04 03:21:00]

Description was changed from

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2599043003
==========

[commit-bot: I haz the power, 2017-01-04 03:21:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 03:24:06]

Description was changed from

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2599043003
==========

to

==========
Add transform and background not opaque as main thread scrolling reasons

BUG=660907
TEST=ScrollingCoordinatorTest.StyleRelatedMainThreadScrollingReasonTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/1bbdf620f45d6d5753ddcad660af175e30e79e13
Cr-Commit-Position: refs/heads/master@{#441308}
==========

[commit-bot: I haz the power, 2017-01-04 03:24:07]

Patchset 2 (id:??) landed as
https://crrev.com/1bbdf620f45d6d5753ddcad660af175e30e79e13
Cr-Commit-Position: refs/heads/master@{#441308}