Remove cc's MainThreadScrollingReason::kEventHandlers

Remove cc's MainThreadScrollingReason::kEventHandlers

This patch removes MainThreadScrollingReason::kEventHandlers which was
only used in tests.

BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/0a17da78678ef631de7583ced1be9c749fcdfbda
Cr-Commit-Position: refs/heads/master@{#420451}

[pdr., 2016-09-21 23:06:14]

Description was changed from

==========
Remove cc's MainThreadScrollingReason::kEventHandlers

This patch removes MainThreadScrollingReason::kEventHandlers which was
only used in tests, and cleans up the MainThreadScrollingReason bit
mask so that kMainThreadScrollingReasonCount is correct.

BUG=644514
==========

to

==========
Remove cc's MainThreadScrollingReason::kEventHandlers

This patch removes MainThreadScrollingReason::kEventHandlers which was
only used in tests, and cleans up the MainThreadScrollingReason bit
mask so that kMainThreadScrollingReasonCount is correct.

BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[pdr., 2016-09-21 23:07:28]

pdr@chromium.org changed reviewers:
+ ajuma@chromium.org, sunxd@chromium.org

[pdr., 2016-09-21 23:07:33]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:08:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:15:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:15:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2016-09-21 23:20:22]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:21:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:33:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2016-09-21 23:41:17]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:42:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:59:56]

Dry run: This issue passed the CQ dry run.

[tdresser, 2016-09-22 13:09:47]

tdresser@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2016-09-22 13:09:47]

We missed cleaning this up when implementing "wheel gestures".

Removing it now SGTM.

[dtapuska, 2016-09-22 13:36:43]

dtapuska@chromium.org changed reviewers:
+ dtapuska@chromium.org

[dtapuska, 2016-09-22 13:36:44]

https://codereview.chromium.org/2360113003/diff/40001/cc/input/main_thread_sc...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/2360113003/diff/40001/cc/input/main_thread_sc...
cc/input/main_thread_scrolling_reason.h:43: enum : uint32_t {
kMainThreadScrollingReasonCount = 16 };
I'm not sure this is right. I think it is supposed to be size + 1.

The max shift size is 15 from looking at the code. So the size is 16. And then
this code uses it
https://cs.chromium.org/chromium/src/ui/events/blink/input_handler_proxy.cc?q...

I'm not saying the usage is right. But just trying to understand the motivation
of this change for this line.

[pdr., 2016-09-22 19:57:18]

Description was changed from

==========
Remove cc's MainThreadScrollingReason::kEventHandlers

This patch removes MainThreadScrollingReason::kEventHandlers which was
only used in tests, and cleans up the MainThreadScrollingReason bit
mask so that kMainThreadScrollingReasonCount is correct.

BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove cc's MainThreadScrollingReason::kEventHandlers

This patch removes MainThreadScrollingReason::kEventHandlers which was
only used in tests.

BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[pdr., 2016-09-22 19:57:40]

https://codereview.chromium.org/2360113003/diff/40001/cc/input/main_thread_sc...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/2360113003/diff/40001/cc/input/main_thread_sc...
cc/input/main_thread_scrolling_reason.h:43: enum : uint32_t {
kMainThreadScrollingReasonCount = 16 };
On 2016/09/22 at 13:36:44, dtapuska wrote:
> I'm not sure this is right. I think it is supposed to be size + 1.
> 
> The max shift size is 15 from looking at the code. So the size is 16. And then
this code uses it
>
https://cs.chromium.org/chromium/src/ui/events/blink/input_handler_proxy.cc?q...
> 
> I'm not saying the usage is right. But just trying to understand the
motivation of this change for this line.

Good catch. This is pretty confusing... if the max is 15 then the count should
be 16 (zero indexed) but you're right that the usage assumes otherwise. I've
backed out this change so that this patch is just the removal of an unused enum.

[dtapuska, 2016-09-22 20:24:46]

On 2016/09/22 19:57:40, pdr. wrote:
>
https://codereview.chromium.org/2360113003/diff/40001/cc/input/main_thread_sc...
> File cc/input/main_thread_scrolling_reason.h (right):
> 
>
https://codereview.chromium.org/2360113003/diff/40001/cc/input/main_thread_sc...
> cc/input/main_thread_scrolling_reason.h:43: enum : uint32_t {
> kMainThreadScrollingReasonCount = 16 };
> On 2016/09/22 at 13:36:44, dtapuska wrote:
> > I'm not sure this is right. I think it is supposed to be size + 1.
> > 
> > The max shift size is 15 from looking at the code. So the size is 16. And
then
> this code uses it
> >
>
https://cs.chromium.org/chromium/src/ui/events/blink/input_handler_proxy.cc?q...
> > 
> > I'm not saying the usage is right. But just trying to understand the
> motivation of this change for this line.
> 
> Good catch. This is pretty confusing... if the max is 15 then the count should
> be 16 (zero indexed) but you're right that the usage assumes otherwise. I've
> backed out this change so that this patch is just the removal of an unused
enum.

lgtm

[pdr., 2016-09-22 20:29:32]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-09-22 20:30:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-09-22 20:30:47]

lgtm too

[commit-bot: I haz the power, 2016-09-22 20:46:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-22 20:48:36]

Description was changed from

==========
Remove cc's MainThreadScrollingReason::kEventHandlers

This patch removes MainThreadScrollingReason::kEventHandlers which was
only used in tests.

BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove cc's MainThreadScrollingReason::kEventHandlers

This patch removes MainThreadScrollingReason::kEventHandlers which was
only used in tests.

BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/0a17da78678ef631de7583ced1be9c749fcdfbda
Cr-Commit-Position: refs/heads/master@{#420451}
==========

[commit-bot: I haz the power, 2016-09-22 20:48:38]

Patchset 4 (id:??) landed as
https://crrev.com/0a17da78678ef631de7583ced1be9c749fcdfbda
Cr-Commit-Position: refs/heads/master@{#420451}