Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 2598973002: [stubs] Remove %_NewObject intrinsic (Closed)

Created:
3 years, 12 months ago by jgruber
Modified:
3 years, 12 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Remove %_NewObject intrinsic The last remaining JS user of this in promise.js has recently been moved to TF. The underlying FastObjectStub is still in use. BUG= Review-Url: https://codereview.chromium.org/2598973002 Cr-Commit-Position: refs/heads/master@{#41919} Committed: https://chromium.googlesource.com/v8/v8/+/132b7bf9e0b85c9b07970b1027617489ae719e87

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (16 generated)
jgruber
This removes access to %_NewObject from JS, but FastNewObjectStub.
3 years, 12 months ago (2016-12-22 10:35:22 UTC) #6
Benedikt Meurer
Nice! LGTM.
3 years, 12 months ago (2016-12-22 10:39:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598973002/1
3 years, 12 months ago (2016-12-22 10:53:04 UTC) #9
commit-bot: I haz the power
Failed to apply patch for src/crankshaft/hydrogen.h: While running git apply --index -p1; error: patch failed: ...
3 years, 12 months ago (2016-12-22 10:55:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598973002/1
3 years, 12 months ago (2016-12-22 12:05:21 UTC) #13
commit-bot: I haz the power
Failed to apply patch for src/crankshaft/hydrogen.h: While running git apply --index -p1; error: patch failed: ...
3 years, 12 months ago (2016-12-22 12:07:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598973002/20001
3 years, 12 months ago (2016-12-22 12:13:40 UTC) #21
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 12:37:24 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/132b7bf9e0b85c9b07970b1027617489ae7...

Powered by Google App Engine
This is Rietveld 408576698