Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2599003002: [async-await] Remove call indirection in Create and Reject (Closed)

Created:
4 years ago by jgruber
Modified:
3 years, 11 months ago
Reviewers:
Dan Ehrenberg, gsathya
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[async-await] Remove call indirection in Create and Reject Instead of exporting/importing PromiseCreate and RejectPromise and going through them, just call the runtime function / the TF builtin on the context directly. BUG=v8:5639 Review-Url: https://codereview.chromium.org/2599003002 Cr-Commit-Position: refs/heads/master@{#42160} Committed: https://chromium.googlesource.com/v8/v8/+/ca4d8136ee8a8db608b5676e37365718c3bf7ded

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove RejectPromise and empty utils.Export call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M src/js/async-await.js View 1 4 chunks +4 lines, -9 lines 0 comments Download
M src/js/promise.js View 1 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
jgruber
4 years ago (2016-12-22 12:38:52 UTC) #4
jgruber
4 years ago (2016-12-22 12:39:24 UTC) #5
Dan Ehrenberg
lgtm
4 years ago (2016-12-22 16:05:24 UTC) #9
gsathya
https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js File src/js/promise.js (right): https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js#newcode75 src/js/promise.js:75: function RejectPromise(promise, reason, debugEvent) { Can this be removed?
4 years ago (2016-12-22 16:19:01 UTC) #10
Dan Ehrenberg
https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js File src/js/promise.js (right): https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js#newcode75 src/js/promise.js:75: function RejectPromise(promise, reason, debugEvent) { On 2016/12/22 16:19:01, gsathya ...
4 years ago (2016-12-22 16:22:32 UTC) #11
gsathya
On 2016/12/22 16:22:32, Dan Ehrenberg wrote: > https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js > File src/js/promise.js (right): > > https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js#newcode75 ...
3 years, 11 months ago (2017-01-06 02:08:57 UTC) #12
jgruber
Rebased this one, PTAL.
3 years, 11 months ago (2017-01-09 09:41:21 UTC) #17
gsathya
lgtm
3 years, 11 months ago (2017-01-09 17:09:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599003002/20001
3 years, 11 months ago (2017-01-10 08:04:52 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 08:06:55 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ca4d8136ee8a8db608b5676e37365718c3b...

Powered by Google App Engine
This is Rietveld 408576698