|
|
Description[async-await] Remove call indirection in Create and Reject
Instead of exporting/importing PromiseCreate and RejectPromise and going
through them, just call the runtime function / the TF builtin on the
context directly.
BUG=v8:5639
Review-Url: https://codereview.chromium.org/2599003002
Cr-Commit-Position: refs/heads/master@{#42160}
Committed: https://chromium.googlesource.com/v8/v8/+/ca4d8136ee8a8db608b5676e37365718c3bf7ded
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove RejectPromise and empty utils.Export call #
Messages
Total messages: 24 (14 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jgruber@chromium.org changed reviewers: + gsathya@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
littledan@chromium.org changed reviewers: + littledan@chromium.org
lgtm
https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js File src/js/promise.js (right): https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js#newcode75 src/js/promise.js:75: function RejectPromise(promise, reason, debugEvent) { Can this be removed?
https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js File src/js/promise.js (right): https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js#newcode75 src/js/promise.js:75: function RejectPromise(promise, reason, debugEvent) { On 2016/12/22 16:19:01, gsathya wrote: > Can this be removed? Yeah, seems like we could remove promise_internal_reject if we just update its one user PromiseRejectClosure to call the runtime function directly. I'm OK with that in a separate patch or the same patch.
On 2016/12/22 16:22:32, Dan Ehrenberg wrote: > https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js > File src/js/promise.js (right): > > https://codereview.chromium.org/2599003002/diff/1/src/js/promise.js#newcode75 > src/js/promise.js:75: function RejectPromise(promise, reason, debugEvent) { > On 2016/12/22 16:19:01, gsathya wrote: > > Can this be removed? > > Yeah, seems like we could remove promise_internal_reject if we just update its > one user PromiseRejectClosure to call the runtime function directly. I'm OK with > that in a separate patch or the same patch. https://codereview.chromium.org/2616673003/
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Rebased this one, PTAL.
lgtm
The CQ bit was checked by jgruber@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from littledan@chromium.org Link to the patchset: https://codereview.chromium.org/2599003002/#ps20001 (title: "Remove RejectPromise and empty utils.Export call")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484035482622490, "parent_rev": "9691f6acbd84ca0aacf1f465fc852e42f7d8cbca", "commit_rev": "ca4d8136ee8a8db608b5676e37365718c3bf7ded"}
Message was sent while issue was closed.
Description was changed from ========== [async-await] Remove call indirection in Create and Reject Instead of exporting/importing PromiseCreate and RejectPromise and going through them, just call the runtime function / the TF builtin on the context directly. BUG=v8:5639 ========== to ========== [async-await] Remove call indirection in Create and Reject Instead of exporting/importing PromiseCreate and RejectPromise and going through them, just call the runtime function / the TF builtin on the context directly. BUG=v8:5639 Review-Url: https://codereview.chromium.org/2599003002 Cr-Commit-Position: refs/heads/master@{#42160} Committed: https://chromium.googlesource.com/v8/v8/+/ca4d8136ee8a8db608b5676e37365718c3b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/ca4d8136ee8a8db608b5676e37365718c3b... |