Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2598813002: Revert of Include -fsanitize=float-cast-overflow in is_ubsan=true builds. (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
krasin1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include -fsanitize=float-cast-overflow in is_ubsan=true builds. (patchset #1 id:1 of https://codereview.chromium.org/2550593004/ ) Reason for revert: Somewhat speculative; it looks like clusterfuzz might use this list and filed many many float overflow bugs (https://bugs.chromium.org/p/chromium/issues/list?can=2&q=%22Float-cast-overflow%22&x=m&y=releaseblock&cells=ids). While we should fix all those, doing so by letting clusterfuzz file close to a hundred bugs assigned to random people isn't the way we should go about it, and CF filing all this bugs wasn't intended when I wrote this CL. Original issue's description: > Include -fsanitize=float-cast-overflow in is_ubsan=true builds. > > Also add a comment about the current state of ubsan. > > BUG=669642 > > Committed: https://crrev.com/2e147959b92ac70c0eb3e0568ae664d39614b68c > Cr-Commit-Position: refs/heads/master@{#436093} TBR=krasin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=669642 Committed: https://crrev.com/c4c7a57c10a808a2eefcc605095fe40fb75b2650 Cr-Commit-Position: refs/heads/master@{#440258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/config/sanitizers/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Nico
Created Revert of Include -fsanitize=float-cast-overflow in is_ubsan=true builds.
4 years ago (2016-12-21 22:14:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598813002/1
4 years ago (2016-12-21 22:15:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 23:12:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4c7a57c10a808a2eefcc605095fe40fb75b2650 Cr-Commit-Position: refs/heads/master@{#440258}
4 years ago (2016-12-21 23:14:22 UTC) #8
krasin1
4 years ago (2016-12-22 00:59:32 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698