Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: build/config/sanitizers/BUILD.gn

Issue 2598813002: Revert of Include -fsanitize=float-cast-overflow in is_ubsan=true builds. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build_overrides/build.gni") 5 import("//build_overrides/build.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/clang/clang.gni") 8 import("//build/config/clang/clang.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 assert(is_linux, "tsan only supported on linux x86_64") 421 assert(is_linux, "tsan only supported on linux x86_64")
422 tsan_blacklist_path = 422 tsan_blacklist_path =
423 rebase_path("//tools/memory/tsan_v2/ignores.txt", root_build_dir) 423 rebase_path("//tools/memory/tsan_v2/ignores.txt", root_build_dir)
424 cflags = [ 424 cflags = [
425 "-fsanitize=thread", 425 "-fsanitize=thread",
426 "-fsanitize-blacklist=$tsan_blacklist_path", 426 "-fsanitize-blacklist=$tsan_blacklist_path",
427 ] 427 ]
428 } 428 }
429 } 429 }
430 430
431 # UBSan is still in bring-up. Chrome builds with is_ubsan=true, but if you
432 # set is_ubsan=true is_ubsan_no_recover = true, then many tests are still
433 # failing.
434 config("ubsan_flags") { 431 config("ubsan_flags") {
435 cflags = [] 432 cflags = []
436 if (is_ubsan) { 433 if (is_ubsan) {
437 ubsan_blacklist_path = 434 ubsan_blacklist_path =
438 rebase_path("//tools/ubsan/blacklist.txt", root_build_dir) 435 rebase_path("//tools/ubsan/blacklist.txt", root_build_dir)
439 cflags += [ 436 cflags += [
440 # Yasm dies with an "Illegal instruction" error when bounds checking is 437 # Yasm dies with an "Illegal instruction" error when bounds checking is
441 # enabled. See http://crbug.com/489901 438 # enabled. See http://crbug.com/489901
442 # "-fsanitize=bounds", 439 # "-fsanitize=bounds",
443 "-fsanitize=float-divide-by-zero", 440 "-fsanitize=float-divide-by-zero",
444 "-fsanitize=float-cast-overflow",
445 "-fsanitize=integer-divide-by-zero", 441 "-fsanitize=integer-divide-by-zero",
446 "-fsanitize=null", 442 "-fsanitize=null",
447 "-fsanitize=object-size", 443 "-fsanitize=object-size",
448 "-fsanitize=return", 444 "-fsanitize=return",
449 "-fsanitize=returns-nonnull-attribute", 445 "-fsanitize=returns-nonnull-attribute",
450 "-fsanitize=shift-exponent", 446 "-fsanitize=shift-exponent",
451 "-fsanitize=signed-integer-overflow", 447 "-fsanitize=signed-integer-overflow",
452 "-fsanitize=unreachable", 448 "-fsanitize=unreachable",
453 "-fsanitize=vla-bound", 449 "-fsanitize=vla-bound",
454 "-fsanitize-blacklist=$ubsan_blacklist_path", 450 "-fsanitize-blacklist=$ubsan_blacklist_path",
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 # This allows to selectively disable ubsan_vptr, when needed. In particular, 535 # This allows to selectively disable ubsan_vptr, when needed. In particular,
540 # if some third_party code is required to be compiled without rtti, which 536 # if some third_party code is required to be compiled without rtti, which
541 # is a requirement for ubsan_vptr. 537 # is a requirement for ubsan_vptr.
542 config("default_sanitizer_flags_but_ubsan_vptr") { 538 config("default_sanitizer_flags_but_ubsan_vptr") {
543 configs = all_sanitizer_configs - [ ":ubsan_vptr_flags" ] 539 configs = all_sanitizer_configs - [ ":ubsan_vptr_flags" ]
544 } 540 }
545 541
546 config("default_sanitizer_flags_but_coverage") { 542 config("default_sanitizer_flags_but_coverage") {
547 configs = all_sanitizer_configs - [ ":coverage_flags" ] 543 configs = all_sanitizer_configs - [ ":coverage_flags" ]
548 } 544 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698