components/offline_pages/core/background/save_page_request.h - Issue 2598573003: Fix for crbug.com/675863 - don't clobber PAUSE state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/background/save_page_request.h

Issue 2598573003: Fix for crbug.com/675863 - don't clobber PAUSE state. (Closed)

Patch Set: CR feedback per DewittJ and DougArnett Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/core/background/save_page_request.h

diff --git a/components/offline_pages/core/background/save_page_request.h b/components/offline_pages/core/background/save_page_request.h

index ab5a760c3d0d8033b94f17f2fd1d1ec8b21614cb..9f9e9ed0ee81ebf2a09c3702fa6b2415dfe8e433 100644

--- a/components/offline_pages/core/background/save_page_request.h

+++ b/components/offline_pages/core/background/save_page_request.h

@@ -45,8 +45,8 @@ class SavePageRequest {

// Marks attempt as completed and clears |last_attempt_time_|.

void MarkAttemptCompleted();

- // Marks attempt as aborted. Specifically it clears |last_attempt_time_|

- // and decrements |attempt_count_|.

+ // Marks attempt as aborted. This will change the state of an OFFLINING

+ // request to be AVAILABLE. It will not change the state of a PAUSED request.

void MarkAttemptAborted();

// Mark the attempt as paused. It is not available for future prerendering