[runtime][ic] Constant field tracking support.

[runtime][ic] Constant field tracking support.

This CL includes runtime and IC parts of the tracking. It is controlled by 
compile-time flag FLAG_constant_field_tracking and currently disabled.

Transition from kConst to kMutable still involves map deprecation.

BUG=v8:5495
Review-Url: https://codereview.chromium.org/2598543003
Cr-Commit-Position: refs/heads/master@{#43081}
Committed: https://chromium.googlesource.com/v8/v8/+/a4f4c7405064cf31e75d57a921f012abfebe1bfd

[Igor Sheludko, 2017-01-16 19:04:20]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2017-01-16 19:04:27]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2017-01-16 19:04:34]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2017-01-16 19:04:40]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2017-01-17 10:48:31]

Patchset #2 (id:100001) has been deleted

[Igor Sheludko, 2017-01-17 10:48:37]

Patchset #1 (id:80001) has been deleted

[Igor Sheludko, 2017-01-17 11:58:16]

Patchset #1 (id:120001) has been deleted

[Igor Sheludko, 2017-01-17 12:12:58]

Description was changed from

==========
WIP: constant tracking

BUG=v8:5495
==========

to

==========
[runtime][ic] Constant field tracking support.

This CL includes runtime and IC parts of the tracking. It is controlled by 
compile-time flag FLAG_constant_field_tracking and currently disabled.

Currently transition from kConst to kMutable involves map deprecation.

BUG=v8:5495
==========

[Igor Sheludko, 2017-01-18 12:02:18]

Patchset #2 (id:160001) has been deleted

[Igor Sheludko, 2017-01-18 12:02:25]

Patchset #1 (id:140001) has been deleted

[Igor Sheludko, 2017-01-19 14:53:50]

Patchset #1 (id:180001) has been deleted

[Igor Sheludko, 2017-01-19 15:06:17]

Patchset #1 (id:200001) has been deleted

[Igor Sheludko, 2017-01-19 15:06:46]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2017-01-19 15:06:46]

PTAL

[Igor Sheludko, 2017-01-19 15:07:40]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 15:07:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-19 15:08:12]

Description was changed from

==========
[runtime][ic] Constant field tracking support.

This CL includes runtime and IC parts of the tracking. It is controlled by 
compile-time flag FLAG_constant_field_tracking and currently disabled.

Currently transition from kConst to kMutable involves map deprecation.

BUG=v8:5495
==========

to

==========
[runtime][ic] Constant field tracking support.

This CL includes runtime and IC parts of the tracking. It is controlled by 
compile-time flag FLAG_constant_field_tracking and currently disabled.

Transition from kConst to kMutable still involves map deprecation.

BUG=v8:5495
==========

[Igor Sheludko, 2017-01-19 15:14:00]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[Igor Sheludko, 2017-01-19 15:14:09]

Patchset #1 (id:220001) has been deleted

[commit-bot: I haz the power, 2017-01-19 15:14:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 15:43:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 15:43:48]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-23 14:51:17]

Patchset #2 (id:260001) has been deleted

[Igor Sheludko, 2017-01-24 16:09:25]

Patchset #2 (id:280001) has been deleted

[Igor Sheludko, 2017-01-24 16:09:36]

Patchset #1 (id:240001) has been deleted

[Toon Verwaest, 2017-02-09 16:06:09]

https://codereview.chromium.org/2598543003/diff/300001/src/lookup.cc
File src/lookup.cc (right):

https://codereview.chromium.org/2598543003/diff/300001/src/lookup.cc#newcode314
src/lookup.cc:314: WriteDataValue(value, true);
Enum? Is this fast enough? I think WriteDataValue is quite perf sensitive.

https://codereview.chromium.org/2598543003/diff/320001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2598543003/diff/320001/src/objects.cc#newcode...
src/objects.cc:4630: bool is_initializing_store =
it->IsInitializingStoreRequired();
I'm not sure this is necessary (anymore?)

https://codereview.chromium.org/2598543003/diff/320001/test/cctest/test-unbox...
File test/cctest/test-unboxed-doubles.cc (right):

https://codereview.chromium.org/2598543003/diff/320001/test/cctest/test-unbox...
test/cctest/test-unboxed-doubles.cc:622: //  Handle<JSFunction> func =
factory->NewFunction(func_name);
delete

[Igor Sheludko, 2017-02-09 17:08:14]

https://codereview.chromium.org/2598543003/diff/300001/src/lookup.cc
File src/lookup.cc (right):

https://codereview.chromium.org/2598543003/diff/300001/src/lookup.cc#newcode314
src/lookup.cc:314: WriteDataValue(value, true);
On 2017/02/09 16:06:09, Toon Verwaest wrote:
> Enum? Is this fast enough? I think WriteDataValue is quite perf sensitive.

See comment in Object::SetDataProperty().

https://codereview.chromium.org/2598543003/diff/320001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2598543003/diff/320001/src/objects.cc#newcode...
src/objects.cc:4630: bool is_initializing_store =
it->IsInitializingStoreRequired();
On 2017/02/09 16:06:09, Toon Verwaest wrote:
> I'm not sure this is necessary (anymore?)

Indeed.

https://codereview.chromium.org/2598543003/diff/320001/src/objects.cc#newcode...
src/objects.cc:4637: it->WriteDataValue(to_assign, is_initializing_store);
But the "initializing_store" parameter is still needed if we want to validate
stores to constant fields.

Although we could probably remove the check completely given that 1) this is the
only code path that does non-initializing stores to fast objects, 2)
PrepareForDataProperty() should have already done the right thing.

Or we can turn "initializing_store" to a template parameter.

WDYT?

https://codereview.chromium.org/2598543003/diff/320001/test/cctest/test-unbox...
File test/cctest/test-unboxed-doubles.cc (right):

https://codereview.chromium.org/2598543003/diff/320001/test/cctest/test-unbox...
test/cctest/test-unboxed-doubles.cc:622: //  Handle<JSFunction> func =
factory->NewFunction(func_name);
On 2017/02/09 16:06:09, Toon Verwaest wrote:
> delete

Done.

[Igor Sheludko, 2017-02-09 17:08:20]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 17:08:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 17:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 17:45:44]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20715)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Igor Sheludko, 2017-02-09 18:05:06]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 18:05:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 18:52:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:52:27]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20722)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Toon Verwaest, 2017-02-10 07:41:41]

lgtm

[Igor Sheludko, 2017-02-10 07:42:35]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-02-10 07:42:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 07:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 07:46:09]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34415)

[Benedikt Meurer, 2017-02-10 07:54:54]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2017-02-10 07:54:54]

lgtm

[Igor Sheludko, 2017-02-10 07:57:56]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-02-10 07:57:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 08:05:26]

CQ is committing da patch.

Bot data: {"patchset_id": 340001, "attempt_start_ts": 1486713476028940,
"parent_rev": "d014b47fe595b1e119b6c177df0b3234bbc0cf24", "commit_rev":
"a4f4c7405064cf31e75d57a921f012abfebe1bfd"}

[commit-bot: I haz the power, 2017-02-10 08:05:31]

Description was changed from

==========
[runtime][ic] Constant field tracking support.

This CL includes runtime and IC parts of the tracking. It is controlled by 
compile-time flag FLAG_constant_field_tracking and currently disabled.

Transition from kConst to kMutable still involves map deprecation.

BUG=v8:5495
==========

to

==========
[runtime][ic] Constant field tracking support.

This CL includes runtime and IC parts of the tracking. It is controlled by 
compile-time flag FLAG_constant_field_tracking and currently disabled.

Transition from kConst to kMutable still involves map deprecation.

BUG=v8:5495

Review-Url: https://codereview.chromium.org/2598543003
Cr-Commit-Position: refs/heads/master@{#43081}
Committed:
https://chromium.googlesource.com/v8/v8/+/a4f4c7405064cf31e75d57a921f012abfeb...
==========

[commit-bot: I haz the power, 2017-02-10 08:05:32]

Committed patchset #3 (id:340001) as
https://chromium.googlesource.com/v8/v8/+/a4f4c7405064cf31e75d57a921f012abfeb...