Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2598543003: [runtime][ic] Constant field tracking support. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime][ic] Constant field tracking support. This CL includes runtime and IC parts of the tracking. It is controlled by compile-time flag FLAG_constant_field_tracking and currently disabled. Transition from kConst to kMutable still involves map deprecation. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2598543003 Cr-Commit-Position: refs/heads/master@{#43081} Committed: https://chromium.googlesource.com/v8/v8/+/a4f4c7405064cf31e75d57a921f012abfebe1bfd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebasing #

Total comments: 5

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+636 lines, -188 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/access-info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/accessor-assembler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/accessor-assembler.cc View 1 7 chunks +45 lines, -6 lines 0 comments Download
M src/ic/handler-configuration.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/ic/handler-configuration-inl.h View 3 chunks +8 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/json-parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lookup.h View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M src/lookup.cc View 1 2 8 chunks +62 lines, -8 lines 0 comments Download
M src/map-updater.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/map-updater.cc View 11 chunks +30 lines, -15 lines 0 comments Download
M src/objects.h View 1 6 chunks +8 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 24 chunks +68 lines, -36 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/property.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/property.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/property-details.h View 4 chunks +12 lines, -0 lines 0 comments Download
M src/value-serializer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-field-type-tracking.cc View 23 chunks +237 lines, -21 lines 0 comments Download
M test/cctest/test-transitions.cc View 6 chunks +23 lines, -17 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 2 16 chunks +79 lines, -68 lines 0 comments Download
M test/mjsunit/compiler/concurrent-invalidate-transition-map.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/field-type-tracking.js View 1 3 chunks +8 lines, -0 lines 0 comments Download
M test/mjsunit/smi-representation.js View 1 chunk +5 lines, -1 line 0 comments Download
M test/mjsunit/track-fields.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 47 (38 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-19 15:06:46 UTC) #14
Toon Verwaest
https://codereview.chromium.org/2598543003/diff/300001/src/lookup.cc File src/lookup.cc (right): https://codereview.chromium.org/2598543003/diff/300001/src/lookup.cc#newcode314 src/lookup.cc:314: WriteDataValue(value, true); Enum? Is this fast enough? I think ...
3 years, 10 months ago (2017-02-09 16:06:09 UTC) #26
Igor Sheludko
https://codereview.chromium.org/2598543003/diff/300001/src/lookup.cc File src/lookup.cc (right): https://codereview.chromium.org/2598543003/diff/300001/src/lookup.cc#newcode314 src/lookup.cc:314: WriteDataValue(value, true); On 2017/02/09 16:06:09, Toon Verwaest wrote: > ...
3 years, 10 months ago (2017-02-09 17:08:14 UTC) #27
Toon Verwaest
lgtm
3 years, 10 months ago (2017-02-10 07:41:41 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598543003/340001
3 years, 10 months ago (2017-02-10 07:42:39 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34415)
3 years, 10 months ago (2017-02-10 07:46:09 UTC) #40
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-02-10 07:54:54 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598543003/340001
3 years, 10 months ago (2017-02-10 07:57:59 UTC) #44
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 08:05:32 UTC) #47
Message was sent while issue was closed.
Committed patchset #3 (id:340001) as
https://chromium.googlesource.com/v8/v8/+/a4f4c7405064cf31e75d57a921f012abfeb...

Powered by Google App Engine
This is Rietveld 408576698