Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: src/ic/ic.cc

Issue 2598543003: [runtime][ic] Constant field tracking support. (Closed)
Patch Set: Addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/handler-configuration-inl.h ('k') | src/json-parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ic/ic.h" 5 #include "src/ic/ic.h"
6 6
7 #include <iostream> 7 #include <iostream>
8 8
9 #include "src/accessors.h" 9 #include "src/accessors.h"
10 #include "src/api-arguments-inl.h" 10 #include "src/api-arguments-inl.h"
(...skipping 2033 matching lines...) Expand 10 before | Expand all | Expand 10 after
2044 DCHECK(holder.is_identical_to(receiver)); 2044 DCHECK(holder.is_identical_to(receiver));
2045 return isolate()->builtins()->StoreIC_Normal(); 2045 return isolate()->builtins()->StoreIC_Normal();
2046 } 2046 }
2047 2047
2048 // -------------- Fields -------------- 2048 // -------------- Fields --------------
2049 if (lookup->property_details().location() == kField) { 2049 if (lookup->property_details().location() == kField) {
2050 TRACE_HANDLER_STATS(isolate(), StoreIC_StoreFieldDH); 2050 TRACE_HANDLER_STATS(isolate(), StoreIC_StoreFieldDH);
2051 int descriptor = lookup->GetFieldDescriptorIndex(); 2051 int descriptor = lookup->GetFieldDescriptorIndex();
2052 FieldIndex index = lookup->GetFieldIndex(); 2052 FieldIndex index = lookup->GetFieldIndex();
2053 return StoreHandler::StoreField(isolate(), descriptor, index, 2053 return StoreHandler::StoreField(isolate(), descriptor, index,
2054 lookup->constness(),
2054 lookup->representation()); 2055 lookup->representation());
2055 } 2056 }
2056 2057
2057 // -------------- Constant properties -------------- 2058 // -------------- Constant properties --------------
2058 DCHECK_EQ(kDescriptor, lookup->property_details().location()); 2059 DCHECK_EQ(kDescriptor, lookup->property_details().location());
2059 TRACE_GENERIC_IC(isolate(), "StoreIC", "constant property"); 2060 TRACE_GENERIC_IC(isolate(), "StoreIC", "constant property");
2060 TRACE_HANDLER_STATS(isolate(), StoreIC_SlowStub); 2061 TRACE_HANDLER_STATS(isolate(), StoreIC_SlowStub);
2061 return slow_stub(); 2062 return slow_stub();
2062 } 2063 }
2063 2064
(...skipping 1091 matching lines...) Expand 10 before | Expand all | Expand 10 after
3155 DCHECK_EQ(LookupIterator::INTERCEPTOR, it.state()); 3156 DCHECK_EQ(LookupIterator::INTERCEPTOR, it.state());
3156 it.Next(); 3157 it.Next();
3157 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, 3158 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result,
3158 Object::GetProperty(&it)); 3159 Object::GetProperty(&it));
3159 } 3160 }
3160 3161
3161 return *result; 3162 return *result;
3162 } 3163 }
3163 } // namespace internal 3164 } // namespace internal
3164 } // namespace v8 3165 } // namespace v8
OLDNEW
« no previous file with comments | « src/ic/handler-configuration-inl.h ('k') | src/json-parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698