Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2598093002: Update GVR to 1.10.0 (Closed)

Created:
4 years ago by bshe
Modified:
3 years, 11 months ago
Reviewers:
girard, bajones, agrieve
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update GVR to 1.10.0 BUG=673409 Committed: https://crrev.com/66370bf28e886bc9177c956a1b41f65ed886b862 Cr-Commit-Position: refs/heads/master@{#441174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_elements.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_math.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/android/gvr/gvr_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M device/vr/android/gvr/gvr_gamepad_data_fetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/gvr-android-sdk/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/gvr-android-sdk/README.chromium View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/gvr-android-sdk/common_library.aar.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/gvr-android-sdk/libgvr_shim_static_arm.a.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/gvr-android-sdk/libgvr_shim_static_arm64.a.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
bshe
I think most of you already OOO. I don't expect to get review after holiday. ...
3 years, 12 months ago (2016-12-23 16:18:35 UTC) #6
bajones
On 2016/12/23 16:18:35, bshe wrote: > I think most of you already OOO. I don't ...
3 years, 12 months ago (2016-12-23 16:28:04 UTC) #7
agrieve
On 2016/12/23 16:28:04, bajones (OOO till January) wrote: > On 2016/12/23 16:18:35, bshe wrote: > ...
3 years, 11 months ago (2017-01-03 15:07:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598093002/1
3 years, 11 months ago (2017-01-03 17:46:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 19:06:01 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:08:00 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66370bf28e886bc9177c956a1b41f65ed886b862
Cr-Commit-Position: refs/heads/master@{#441174}

Powered by Google App Engine
This is Rietveld 408576698