Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2598073003: [SPInvalidation] Update paint properties of frame subtree when unthrottled (Closed)

Created:
3 years, 12 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPInvalidation] Update paint properties of frame subtree when unthrottled BUG=645667 TEST=FrameThrottlingTest.MutatingThrottledFrameDoesNotCauseAnimation etc. with --enable-slimming-paint-invalidation Committed: https://crrev.com/f1ebd4aac27a8b10650afd19f28fef936143ced6 Cr-Commit-Position: refs/heads/master@{#440823}

Patch Set 1 #

Patch Set 2 : Test #

Patch Set 3 : Disable the new test for non-SlimmingPaintInvalidation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 2 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Xianzhu
3 years, 12 months ago (2016-12-27 17:42:04 UTC) #6
chrishtr
Looks correct, but this CL needs a test.
3 years, 12 months ago (2016-12-27 18:06:15 UTC) #7
Xianzhu
On 2016/12/27 18:06:15, chrishtr wrote: > Looks correct, but this CL needs a test. Done. ...
3 years, 11 months ago (2016-12-27 23:59:34 UTC) #8
chrishtr
lgtm
3 years, 11 months ago (2016-12-28 00:33:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598073003/40001
3 years, 11 months ago (2016-12-28 01:13:05 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2016-12-28 02:28:07 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:19 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f1ebd4aac27a8b10650afd19f28fef936143ced6
Cr-Commit-Position: refs/heads/master@{#440823}

Powered by Google App Engine
This is Rietveld 408576698