Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2598073003: [SPInvalidation] Update paint properties of frame subtree when unthrottled (Closed)
Patch Set: Disable the new test for non-SlimmingPaintInvalidation Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 4598 matching lines...) Expand 10 before | Expand all | Expand 10 after
4609 scrollingCoordinator->notifyGeometryChanged(); 4609 scrollingCoordinator->notifyGeometryChanged();
4610 // Start ticking animation frames again if necessary. 4610 // Start ticking animation frames again if necessary.
4611 if (page()) 4611 if (page())
4612 page()->animator().scheduleVisualUpdate(m_frame.get()); 4612 page()->animator().scheduleVisualUpdate(m_frame.get());
4613 // Force a full repaint of this frame to ensure we are not left with a 4613 // Force a full repaint of this frame to ensure we are not left with a
4614 // partially painted version of this frame's contents if we skipped 4614 // partially painted version of this frame's contents if we skipped
4615 // painting them while the frame was throttled. 4615 // painting them while the frame was throttled.
4616 LayoutViewItem layoutViewItem = this->layoutViewItem(); 4616 LayoutViewItem layoutViewItem = this->layoutViewItem();
4617 if (!layoutViewItem.isNull()) 4617 if (!layoutViewItem.isNull())
4618 layoutViewItem.invalidatePaintForViewAndCompositedLayers(); 4618 layoutViewItem.invalidatePaintForViewAndCompositedLayers();
4619 // Also need to update all paint properties that might be skipped while
4620 // the frame was throttled.
4621 setSubtreeNeedsPaintPropertyUpdate();
4619 } 4622 }
4620 4623
4621 bool hasHandlers = m_frame->host() && 4624 bool hasHandlers = m_frame->host() &&
4622 m_frame->host()->eventHandlerRegistry().hasEventHandlers( 4625 m_frame->host()->eventHandlerRegistry().hasEventHandlers(
4623 EventHandlerRegistry::TouchStartOrMoveEventBlocking); 4626 EventHandlerRegistry::TouchStartOrMoveEventBlocking);
4624 if (wasThrottled != canThrottleRendering() && scrollingCoordinator && 4627 if (wasThrottled != canThrottleRendering() && scrollingCoordinator &&
4625 hasHandlers) 4628 hasHandlers)
4626 scrollingCoordinator->touchEventTargetRectsDidChange(); 4629 scrollingCoordinator->touchEventTargetRectsDidChange();
4627 4630
4628 if (m_frame->frameScheduler()) { 4631 if (m_frame->frameScheduler()) {
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
4893 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount; 4896 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount;
4894 ++reason) { 4897 ++reason) {
4895 if (m_mainThreadScrollingReasonsCounter[reason] > 0) { 4898 if (m_mainThreadScrollingReasonsCounter[reason] > 0) {
4896 reasons |= 1 << (reason - 1); 4899 reasons |= 1 << (reason - 1);
4897 } 4900 }
4898 } 4901 }
4899 return reasons; 4902 return reasons;
4900 } 4903 }
4901 4904
4902 } // namespace blink 4905 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698