[ios] Removed CookieStoreIOS::UnSynchronize.

[ios] Removed CookieStoreIOS::UnSynchronize.

This method was called when the last incognito tab was closed to prevent
Synchronizing incognito cookies with shared cookie storage. WKWebView's
incognito is ephemeral and web view cookies are not stored anywhere and
not accessible for Chrome app.

Also removed SwitchSynchronizedStore which was used only in tests and
made SetSynchronizedWithSystemStore public to keep it using in tests for now
(instead of UnSynchronize and SwitchSynchronizedStore). Once most of
CookieStoreIOS methods are removed it should be easier to remove
SetSynchronizedWithSystemStore as well.

BUG=676144
Committed: https://crrev.com/61488b67c9a2cf7fbe27b49e312531bb80af8f13
Cr-Commit-Position: refs/heads/master@{#440638}

[Eugene But (OOO till 7-30), 2016-12-22 23:46:51]

Description was changed from

==========
[ios] Removed CookieStoreIOS::UnSynchronize.

This method was called when the last incognito tab was closed to prevent
Synchronizing incognito cookies with shared cookie storage. WKWebView's
incognito is ephemeral and web view cookies are not stored anywhere and
not accesible for Chrome app.


BUG=676144
==========

to

==========
[ios] Removed CookieStoreIOS::UnSynchronize.

This method was called when the last incognito tab was closed to prevent
Synchronizing incognito cookies with shared cookie storage. WKWebView's
incognito is ephemeral and web view cookies are not stored anywhere and
not accessible for Chrome app.

Also removed SwitchSynchronizedStore which was used only in tests and
made SetSynchronizedWithSystemStore public to keep it using in tests for now
instead of UnSynchronize and SwitchSynchronizedStore). Once most of
CookieStoreIOS methods are removed it should be easier to remove
SetSynchronizedWithSystemStore as well.

BUG=676144
==========

[Eugene But (OOO till 7-30), 2016-12-22 23:47:23]

Description was changed from

==========
[ios] Removed CookieStoreIOS::UnSynchronize.

This method was called when the last incognito tab was closed to prevent
Synchronizing incognito cookies with shared cookie storage. WKWebView's
incognito is ephemeral and web view cookies are not stored anywhere and
not accessible for Chrome app.

Also removed SwitchSynchronizedStore which was used only in tests and
made SetSynchronizedWithSystemStore public to keep it using in tests for now
instead of UnSynchronize and SwitchSynchronizedStore). Once most of
CookieStoreIOS methods are removed it should be easier to remove
SetSynchronizedWithSystemStore as well.

BUG=676144
==========

to

==========
[ios] Removed CookieStoreIOS::UnSynchronize.

This method was called when the last incognito tab was closed to prevent
Synchronizing incognito cookies with shared cookie storage. WKWebView's
incognito is ephemeral and web view cookies are not stored anywhere and
not accessible for Chrome app.

Also removed SwitchSynchronizedStore which was used only in tests and
made SetSynchronizedWithSystemStore public to keep it using in tests for now
(instead of UnSynchronize and SwitchSynchronizedStore). Once most of
CookieStoreIOS methods are removed it should be easier to remove
SetSynchronizedWithSystemStore as well.

BUG=676144
==========

[Eugene But (OOO till 7-30), 2016-12-22 23:48:00]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 23:48:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 23:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 23:58:49]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eugene But (OOO till 7-30), 2016-12-23 01:27:48]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 01:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 01:33:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 01:33:49]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2016-12-23 02:03:39]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 02:03:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 02:13:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 02:13:33]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-12-23 03:49:24]

eugenebut@chromium.org changed reviewers:
+ marq@chromium.org

[marq (ping after 24h), 2016-12-23 09:57:03]

lgtm

[Eugene But (OOO till 7-30), 2016-12-23 16:27:54]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-12-23 16:28:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 16:32:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482510474974760,
"parent_rev": "6207acc1a9167514268764f244719660a16d4a46", "commit_rev":
"b15a0db2af98aaba90f546fa278ab985be5b488c"}

[commit-bot: I haz the power, 2016-12-23 16:32:33]

Description was changed from

==========
[ios] Removed CookieStoreIOS::UnSynchronize.

This method was called when the last incognito tab was closed to prevent
Synchronizing incognito cookies with shared cookie storage. WKWebView's
incognito is ephemeral and web view cookies are not stored anywhere and
not accessible for Chrome app.

Also removed SwitchSynchronizedStore which was used only in tests and
made SetSynchronizedWithSystemStore public to keep it using in tests for now
(instead of UnSynchronize and SwitchSynchronizedStore). Once most of
CookieStoreIOS methods are removed it should be easier to remove
SetSynchronizedWithSystemStore as well.

BUG=676144
==========

to

==========
[ios] Removed CookieStoreIOS::UnSynchronize.

This method was called when the last incognito tab was closed to prevent
Synchronizing incognito cookies with shared cookie storage. WKWebView's
incognito is ephemeral and web view cookies are not stored anywhere and
not accessible for Chrome app.

Also removed SwitchSynchronizedStore which was used only in tests and
made SetSynchronizedWithSystemStore public to keep it using in tests for now
(instead of UnSynchronize and SwitchSynchronizedStore). Once most of
CookieStoreIOS methods are removed it should be easier to remove
SetSynchronizedWithSystemStore as well.

BUG=676144

Review-Url: https://codereview.chromium.org/2597933003
==========

[commit-bot: I haz the power, 2016-12-23 16:32:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-23 16:34:16]

Description was changed from

==========
[ios] Removed CookieStoreIOS::UnSynchronize.

This method was called when the last incognito tab was closed to prevent
Synchronizing incognito cookies with shared cookie storage. WKWebView's
incognito is ephemeral and web view cookies are not stored anywhere and
not accessible for Chrome app.

Also removed SwitchSynchronizedStore which was used only in tests and
made SetSynchronizedWithSystemStore public to keep it using in tests for now
(instead of UnSynchronize and SwitchSynchronizedStore). Once most of
CookieStoreIOS methods are removed it should be easier to remove
SetSynchronizedWithSystemStore as well.

BUG=676144

Review-Url: https://codereview.chromium.org/2597933003
==========

to

==========
[ios] Removed CookieStoreIOS::UnSynchronize.

This method was called when the last incognito tab was closed to prevent
Synchronizing incognito cookies with shared cookie storage. WKWebView's
incognito is ephemeral and web view cookies are not stored anywhere and
not accessible for Chrome app.

Also removed SwitchSynchronizedStore which was used only in tests and
made SetSynchronizedWithSystemStore public to keep it using in tests for now
(instead of UnSynchronize and SwitchSynchronizedStore). Once most of
CookieStoreIOS methods are removed it should be easier to remove
SetSynchronizedWithSystemStore as well.

BUG=676144

Committed: https://crrev.com/61488b67c9a2cf7fbe27b49e312531bb80af8f13
Cr-Commit-Position: refs/heads/master@{#440638}
==========

[commit-bot: I haz the power, 2016-12-23 16:34:17]

Patchset 3 (id:??) landed as
https://crrev.com/61488b67c9a2cf7fbe27b49e312531bb80af8f13
Cr-Commit-Position: refs/heads/master@{#440638}