Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: ios/net/cookies/cookie_store_ios.h

Issue 2597933003: [ios] Removed CookieStoreIOS::UnSynchronize. (Closed)
Patch Set: Actually fixed compilation Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/app/main_controller.mm ('k') | ios/net/cookies/cookie_store_ios.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/net/cookies/cookie_store_ios.h
diff --git a/ios/net/cookies/cookie_store_ios.h b/ios/net/cookies/cookie_store_ios.h
index 80610d58d3ff178572949c6158859979109e07b8..6d37364c29225d5b386c18e5c9bee52098580814 100644
--- a/ios/net/cookies/cookie_store_ios.h
+++ b/ios/net/cookies/cookie_store_ios.h
@@ -83,20 +83,12 @@ class CookieStoreIOS : public net::CookieStore,
static std::unique_ptr<CookieStoreIOS> CreateCookieStore(
NSHTTPCookieStorage* cookie_storage);
- // As there is only one system store, only one CookieStoreIOS at a time may
- // be synchronized with it.
- static void SwitchSynchronizedStore(CookieStoreIOS* old_store,
- CookieStoreIOS* new_store);
-
// Must be called when the state of
// |NSHTTPCookieStorage sharedHTTPCookieStorage| changes.
// Affects only those CookieStoreIOS instances that are backed by
// |NSHTTPCookieStorage sharedHTTPCookieStorage|.
static void NotifySystemCookiesChanged();
- // Unsynchronizes the cookie store if it is currently synchronized.
- void UnSynchronize();
-
// Only one cookie store may enable metrics.
void SetMetricsEnabled();
@@ -156,6 +148,13 @@ class CookieStoreIOS : public net::CookieStore,
bool IsEphemeral() override;
+ // Changes the synchronization of the store.
+ // If |synchronized| is true, then the system cookie store is used as a
+ // backend, else |cookie_monster_| is used. Cookies are moved from one to
+ // the other accordingly.
+ // TODO(crbug.com/676144): Remove this method. It is used only in tests.
+ void SetSynchronizedWithSystemStore(bool synchronized);
+
private:
// For tests.
friend struct CookieStoreIOSTestTraits;
@@ -173,11 +172,6 @@ class CookieStoreIOS : public net::CookieStore,
// Clears the system cookie store.
void ClearSystemStore();
- // Changes the synchronization of the store.
- // If |synchronized| is true, then the system cookie store is used as a
- // backend, else |cookie_monster_| is used. Cookies are moved from one to
- // the other accordingly.
- void SetSynchronizedWithSystemStore(bool synchronized);
// Returns true if the system cookie store policy is
// |NSHTTPCookieAcceptPolicyAlways|.
bool SystemCookiesAllowed();
« no previous file with comments | « ios/chrome/app/main_controller.mm ('k') | ios/net/cookies/cookie_store_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698