Make SupportsUserData sequence-affine instead of thread-affine.

Make SupportsUserData sequence-affine instead of thread-affine.

This is making progress in issue 675631 as well as unblocking
https://codereview.chromium.org/2592813002/ (per
AndroidProviderBackend::FromHistoryBackend()'s usage).

BUG=675631
TBR=clamy,nhiroki (for side-effects in content/ and storage/browser/fileapi/)

Committed: https://crrev.com/7b1d6771691b1ba6798342835ba472942e956423
Cr-Commit-Position: refs/heads/master@{#440406}

[gab, 2016-12-21 21:54:27]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2016-12-21 21:55:10]

Description was changed from

==========
Make SupportsUserData sequence-affine instead of thread-affine.

This is making progress in issue 675631 as well as unblocking
https://codereview.chromium.org/2592813002/.

BUG=675631
==========

to

==========
Make SupportsUserData sequence-affine instead of thread-affine.

This is making progress in issue 675631 as well as unblocking
https://codereview.chromium.org/2592813002/ (per
AndroidProviderBackend::FromHistoryBackend()'s usage).

BUG=675631
==========

[commit-bot: I haz the power, 2016-12-21 21:55:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-12-21 21:56:03]

gab@chromium.org changed reviewers:
+ dcheng@chromium.org

[gab, 2016-12-21 21:56:03]

Daniel PTAL, thanks!

[commit-bot: I haz the power, 2016-12-21 22:06:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:06:04]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[dcheng, 2016-12-21 23:25:57]

Looks like a lot of bots are unhappy: I think sequence_checker is in //base, not
//base/threading.

[gab, 2016-12-22 01:38:14]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2016-12-22 01:38:23]

On 2016/12/21 23:25:57, dcheng wrote:
> Looks like a lot of bots are unhappy: I think sequence_checker is in //base,
not
> //base/threading.

Oops, indeed, fixed.

PS: How about we move that header to base/threading? It's kind of silly that
they're not together...

[commit-bot: I haz the power, 2016-12-22 01:38:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:46:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 01:46:51]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gab, 2016-12-22 01:51:50]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 01:52:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 02:02:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 02:02:20]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[gab, 2016-12-22 02:27:01]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 02:27:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 03:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 03:38:07]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-12-22 04:57:55]

lgtm

i'm not sure about moving the header to threading; I feel like we've been trying
to separate the concept of threading from sequencing.

https://codereview.chromium.org/2597773002/diff/60001/base/supports_user_data.h
File base/supports_user_data.h (right):

https://codereview.chromium.org/2597773002/diff/60001/base/supports_user_data...
base/supports_user_data.h:17: // remove it in a follow- up CL.
sob

[gab, 2016-12-22 12:00:27]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-12-22 12:00:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 12:06:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 12:06:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[gab, 2016-12-22 13:59:15]

Description was changed from

==========
Make SupportsUserData sequence-affine instead of thread-affine.

This is making progress in issue 675631 as well as unblocking
https://codereview.chromium.org/2592813002/ (per
AndroidProviderBackend::FromHistoryBackend()'s usage).

BUG=675631
==========

to

==========
Make SupportsUserData sequence-affine instead of thread-affine.

This is making progress in issue 675631 as well as unblocking
https://codereview.chromium.org/2592813002/ (per
AndroidProviderBackend::FromHistoryBackend()'s usage).

BUG=675631
TBR=clamy,nhiroki (for side-effects in content/ and storage/browser/fileapi/)
==========

[gab, 2016-12-22 13:59:15]

gab@chromium.org changed reviewers:
+ clamy@chromium.org, nhiroki@chromium.org

[gab, 2016-12-22 14:01:14]

On 2016/12/22 04:57:55, dcheng wrote:
> lgtm

Thanks, TBR=clamy,nhiroki (for side-effects in content/ and
storage/browser/fileapi/)

> 
> i'm not sure about moving the header to threading; I feel like we've been
trying
> to separate the concept of threading from sequencing.

Sequencing is related to threading IMO and as I'm looking to take most of Chrome
from being thread-affine to being sequence-affine this is something I want to
figure out. I'll come up with a follow-up proposal.

> 
>
https://codereview.chromium.org/2597773002/diff/60001/base/supports_user_data.h
> File base/supports_user_data.h (right):
> 
>
https://codereview.chromium.org/2597773002/diff/60001/base/supports_user_data...
> base/supports_user_data.h:17: // remove it in a follow- up CL.
> sob

[gab, 2016-12-22 14:01:18]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-12-22 14:01:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 14:05:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482415278699360,
"parent_rev": "3bf6add9f6c82fabe5ae30d17147e92bf2580e31", "commit_rev":
"89974c156619c20aea911fbc72a9820575d61940"}

[commit-bot: I haz the power, 2016-12-22 14:05:47]

Description was changed from

==========
Make SupportsUserData sequence-affine instead of thread-affine.

This is making progress in issue 675631 as well as unblocking
https://codereview.chromium.org/2592813002/ (per
AndroidProviderBackend::FromHistoryBackend()'s usage).

BUG=675631
TBR=clamy,nhiroki (for side-effects in content/ and storage/browser/fileapi/)
==========

to

==========
Make SupportsUserData sequence-affine instead of thread-affine.

This is making progress in issue 675631 as well as unblocking
https://codereview.chromium.org/2592813002/ (per
AndroidProviderBackend::FromHistoryBackend()'s usage).

BUG=675631
TBR=clamy,nhiroki (for side-effects in content/ and storage/browser/fileapi/)

Review-Url: https://codereview.chromium.org/2597773002
==========

[commit-bot: I haz the power, 2016-12-22 14:05:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-22 14:08:53]

Description was changed from

==========
Make SupportsUserData sequence-affine instead of thread-affine.

This is making progress in issue 675631 as well as unblocking
https://codereview.chromium.org/2592813002/ (per
AndroidProviderBackend::FromHistoryBackend()'s usage).

BUG=675631
TBR=clamy,nhiroki (for side-effects in content/ and storage/browser/fileapi/)

Review-Url: https://codereview.chromium.org/2597773002
==========

to

==========
Make SupportsUserData sequence-affine instead of thread-affine.

This is making progress in issue 675631 as well as unblocking
https://codereview.chromium.org/2592813002/ (per
AndroidProviderBackend::FromHistoryBackend()'s usage).

BUG=675631
TBR=clamy,nhiroki (for side-effects in content/ and storage/browser/fileapi/)

Committed: https://crrev.com/7b1d6771691b1ba6798342835ba472942e956423
Cr-Commit-Position: refs/heads/master@{#440406}
==========

[commit-bot: I haz the power, 2016-12-22 14:08:54]

Patchset 4 (id:??) landed as
https://crrev.com/7b1d6771691b1ba6798342835ba472942e956423
Cr-Commit-Position: refs/heads/master@{#440406}