Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2597303002:
Add a .clang-format for chrome/browser/resources (Closed)
DescriptionAdd a .clang-format for chrome/browser/resources
I hope to enlist folks to help running this on various sub-directories.
"clang-format Is Beautiful And Terrifying At The Same Time Like Nature Itself"
- Superba snackbar (paraphrased)
R=groby@chromium.org
BUG=567770
NOTRY=true
Committed: https://crrev.com/cd2e28ea4acfaaa17448baedc06f8595a2789f12
Cr-Commit-Position: refs/heads/master@{#440504}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (9 generated)
Description was changed from ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. R=groby@chromium.org BUG=567770 ========== to ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. R=groby@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. R=groby@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. "clang-format Is Beautiful And Terrifying At The Same Time Like Nature Itself" - Superba snackbar (paraphrased) R=groby@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. "clang-format Is Beautiful And Terrifying At The Same Time Like Nature Itself" - Superba snackbar (paraphrased) R=groby@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. "clang-format Is Beautiful And Terrifying At The Same Time Like Nature Itself" - Superba snackbar (paraphrased) R=groby@chromium.org BUG=567770 NOTRY=true ==========
stevenjb@chromium.org changed reviewers: + stevenjb@chromium.org
https://codereview.chromium.org/2597303002/diff/1/chrome/browser/resources/.c... File chrome/browser/resources/.clang-format (right): https://codereview.chromium.org/2597303002/diff/1/chrome/browser/resources/.c... chrome/browser/resources/.clang-format:5: JavaScriptQuotes: Leave Does this break things in all subdirectories? If it's just, say, the options UI, maye only add this there?
https://codereview.chromium.org/2597303002/diff/1/chrome/browser/resources/.c... File chrome/browser/resources/.clang-format (right): https://codereview.chromium.org/2597303002/diff/1/chrome/browser/resources/.c... chrome/browser/resources/.clang-format:5: JavaScriptQuotes: Leave On 2016/12/22 20:51:34, stevenjb wrote: > Does this break things in all subdirectories? If it's just, say, the options UI, > maye only add this there? Anywhere that does <include src="blah.js"> will get changed to <include src='blah.js'> and break. I've sent a CL to better handle single quotes in <if> and <include> here: https://codereview.chromium.org/2598863002/ But I don't want to wait on that. We can also remove this line and re-run clang-format.
Ah, OK. lgtm. On Thu, Dec 22, 2016 at 12:54 PM, <dbeam@chromium.org> wrote: > > https://codereview.chromium.org/2597303002/diff/1/chrome/ > browser/resources/.clang-format > File chrome/browser/resources/.clang-format (right): > > https://codereview.chromium.org/2597303002/diff/1/chrome/ > browser/resources/.clang-format#newcode5 > chrome/browser/resources/.clang-format:5: JavaScriptQuotes: Leave > On 2016/12/22 20:51:34, stevenjb wrote: > > Does this break things in all subdirectories? If it's just, say, the > options UI, > > maye only add this there? > > Anywhere that does <include src="blah.js"> will get changed to <include > src='blah.js'> and break. > > I've sent a CL to better handle single quotes in <if> and <include> > here: > https://codereview.chromium.org/2598863002/ > > But I don't want to wait on that. We can also remove this line and > re-run clang-format. > > https://codereview.chromium.org/2597303002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
rs LGTM
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482441259311250, "parent_rev":
"b761dc6d9ae2529f3fd7f5220b26de1ea5ce4c00", "commit_rev":
"f7bf9cb1e479e7d1d8c523b0439e834c05c29a8a"}
Message was sent while issue was closed.
Description was changed from ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. "clang-format Is Beautiful And Terrifying At The Same Time Like Nature Itself" - Superba snackbar (paraphrased) R=groby@chromium.org BUG=567770 NOTRY=true ========== to ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. "clang-format Is Beautiful And Terrifying At The Same Time Like Nature Itself" - Superba snackbar (paraphrased) R=groby@chromium.org BUG=567770 NOTRY=true Review-Url: https://codereview.chromium.org/2597303002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. "clang-format Is Beautiful And Terrifying At The Same Time Like Nature Itself" - Superba snackbar (paraphrased) R=groby@chromium.org BUG=567770 NOTRY=true Review-Url: https://codereview.chromium.org/2597303002 ========== to ========== Add a .clang-format for chrome/browser/resources I hope to enlist folks to help running this on various sub-directories. "clang-format Is Beautiful And Terrifying At The Same Time Like Nature Itself" - Superba snackbar (paraphrased) R=groby@chromium.org BUG=567770 NOTRY=true Committed: https://crrev.com/cd2e28ea4acfaaa17448baedc06f8595a2789f12 Cr-Commit-Position: refs/heads/master@{#440504} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cd2e28ea4acfaaa17448baedc06f8595a2789f12 Cr-Commit-Position: refs/heads/master@{#440504} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
