chrome/browser/resources/.clang-format - Issue 2597303002: Add a .clang-format for chrome/browser/resources

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/.clang-format

Issue 2597303002: Add a .clang-format for chrome/browser/resources (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 BasedOnStyle: Chromium

	2

	3 # Renaming quotes in <include> and <if> break things.

	4 # For normal JS code, please prefer ' to ".

	5 JavaScriptQuotes: Leave
	stevenjb 2016/12/22 20:51:34 Does this break things in all subdirectories? If i Does this break things in all subdirectories? If it's just, say, the options UI, maye only add this there? Dan Beam 2016/12/22 20:54:30 Anywhere that does <include src="blah.js"> will ge Show quoted text On 2016/12/22 20:51:34, stevenjb wrote: > Does this break things in all subdirectories? If it's just, say, the options UI, > maye only add this there? Anywhere that does <include src="blah.js"> will get changed to <include src='blah.js'> and break. I've sent a CL to better handle single quotes in <if> and <include> here: https://codereview.chromium.org/2598863002/ But I don't want to wait on that. We can also remove this line and re-run clang-format.
	6

	7 AllowShortBlocksOnASingleLine: false

	8 AllowShortCaseLabelsOnASingleLine: false

	9 AllowShortFunctionsOnASingleLine: false

	10 AllowShortIfStatementsOnASingleLine: false

	11 AllowShortLoopsOnASingleLine: false

	12 SpacesInContainerLiterals: false

	13 SpacesInSquareBrackets: false

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »