Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2597133003: Created a test for window.location.reload(). (Closed)

Created:
3 years, 12 months ago by kkhorimoto
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Created a test for window.location.reload(). BUG=673022 Review-Url: https://codereview.chromium.org/2597133003 Cr-Commit-Position: refs/heads/master@{#445119} Committed: https://chromium.googlesource.com/chromium/src/+/e63937d8dc5cf8ebbeb8706b4f7179f3d7d84ee5

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M ios/web/navigation/window_location_inttest.mm View 1 2 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
kkhorimoto
3 years, 12 months ago (2016-12-23 01:34:09 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2597133003/diff/1/ios/web/navigation/window_location_inttest.mm File ios/web/navigation/window_location_inttest.mm (right): https://codereview.chromium.org/2597133003/diff/1/ios/web/navigation/window_location_inttest.mm#newcode301 ios/web/navigation/window_location_inttest.mm:301: EXPECT_EQ(1, (NSInteger)navigation_manager()->GetItemCount()); Please don't use C-style casting, also ...
3 years, 12 months ago (2016-12-23 01:57:35 UTC) #3
kkhorimoto
https://codereview.chromium.org/2597133003/diff/1/ios/web/navigation/window_location_inttest.mm File ios/web/navigation/window_location_inttest.mm (right): https://codereview.chromium.org/2597133003/diff/1/ios/web/navigation/window_location_inttest.mm#newcode301 ios/web/navigation/window_location_inttest.mm:301: EXPECT_EQ(1, (NSInteger)navigation_manager()->GetItemCount()); On 2016/12/23 01:57:34, Eugene But wrote: > ...
3 years, 11 months ago (2017-01-20 00:38:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597133003/20001
3 years, 11 months ago (2017-01-20 19:00:22 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:12:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e63937d8dc5cf8ebbeb8706b4f71...

Powered by Google App Engine
This is Rietveld 408576698