Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2594363003: Created a test for assigning a string to window.location. (Closed)

Created:
4 years ago by kkhorimoto
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Created a test for assigning a string to window.location. BUG=673022 Review-Url: https://codereview.chromium.org/2594363003 Cr-Commit-Position: refs/heads/master@{#445131} Committed: https://chromium.googlesource.com/chromium/src/+/95d35ca10ca853e71051e645596d8d4b19774cbc

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M ios/web/navigation/window_location_inttest.mm View 1 2 chunks +28 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
kkhorimoto
4 years ago (2016-12-23 01:35:04 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years ago (2016-12-23 01:59:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594363003/20001
3 years, 11 months ago (2017-01-20 19:21:45 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:36:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/95d35ca10ca853e71051e645596d...

Powered by Google App Engine
This is Rietveld 408576698