Update TaskTraits in sw_reporter_installer_win.cc.

Update TaskTraits in sw_reporter_installer_win.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73HeKIjX7HQqwSWOnF8/edit?usp=sharing

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660
Committed: https://crrev.com/6d75b05502d01d81785a502403fc69e8111ab0d8
Cr-Commit-Position: refs/heads/master@{#440156}

[fdoray, 2016-12-21 15:49:13]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:49:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-21 16:07:50]

fdoray@chromium.org changed reviewers:
+ sorin@chromium.org

[fdoray, 2016-12-21 16:07:51]

PTAL

[gab, 2016-12-21 16:11:01]

lgtm w/ comment

https://codereview.chromium.org/2596853002/diff/1/chrome/browser/component_up...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/2596853002/diff/1/chrome/browser/component_up...
chrome/browser/component_updater/sw_reporter_installer_win.cc:140: // process,
hence MayBlock() and WithSyncPrimitives().
// Runs LaunchAndWaitForExit() which creates (MayBlock()) and joins
(WithSyncPrimitives()) a process.

(to be specific about which operation requires which trait?)

[joenotcharles, 2016-12-21 16:20:36]

joenotcharles@google.com changed reviewers:
+ joenotcharles@google.com

[joenotcharles, 2016-12-21 16:20:37]

https://codereview.chromium.org/2596853002/diff/1/chrome/browser/component_up...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/2596853002/diff/1/chrome/browser/component_up...
chrome/browser/component_updater/sw_reporter_installer_win.cc:140: // process,
hence MayBlock() and WithSyncPrimitives().
On 2016/12/21 16:11:01, gab wrote:
> // Runs LaunchAndWaitForExit() which creates (MayBlock()) and joins
> (WithSyncPrimitives()) a process.
> 
> (to be specific about which operation requires which trait?)

Yes, please clarify this.

[fdoray, 2016-12-21 16:28:42]

PTAnL

https://codereview.chromium.org/2596853002/diff/1/chrome/browser/component_up...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/2596853002/diff/1/chrome/browser/component_up...
chrome/browser/component_updater/sw_reporter_installer_win.cc:140: // process,
hence MayBlock() and WithSyncPrimitives().
On 2016/12/21 16:20:36, joenotcharles wrote:
> On 2016/12/21 16:11:01, gab wrote:
> > // Runs LaunchAndWaitForExit() which creates (MayBlock()) and joins
> > (WithSyncPrimitives()) a process.
> > 
> > (to be specific about which operation requires which trait?)
> 
> Yes, please clarify this.

Done.

[joenotcharles, 2016-12-21 16:45:09]

lgtm

[Sorin Jianu, 2016-12-21 17:17:38]

lgtm

Thank you!

[fdoray, 2016-12-21 17:22:27]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-12-21 17:22:27]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2596853002/#ps20001
(title: "clarify comment")

[commit-bot: I haz the power, 2016-12-21 17:23:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 18:15:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482340947356640,
"parent_rev": "94157de5e37f56c21b504113920a2e1b7b29c02c", "commit_rev":
"0ca71370b2d8a8e6347d24b2574da70aa92b2085"}

[commit-bot: I haz the power, 2016-12-21 18:15:54]

Description was changed from

==========
Update TaskTraits in sw_reporter_installer_win.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660
==========

to

==========
Update TaskTraits in sw_reporter_installer_win.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2596853002
==========

[commit-bot: I haz the power, 2016-12-21 18:15:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 18:18:53]

Description was changed from

==========
Update TaskTraits in sw_reporter_installer_win.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2596853002
==========

to

==========
Update TaskTraits in sw_reporter_installer_win.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660

Committed: https://crrev.com/6d75b05502d01d81785a502403fc69e8111ab0d8
Cr-Commit-Position: refs/heads/master@{#440156}
==========

[commit-bot: I haz the power, 2016-12-21 18:18:54]

Patchset 2 (id:??) landed as
https://crrev.com/6d75b05502d01d81785a502403fc69e8111ab0d8
Cr-Commit-Position: refs/heads/master@{#440156}