Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8174)

Unified Diff: chrome/browser/component_updater/sw_reporter_installer_win.cc

Issue 2596853002: Update TaskTraits in sw_reporter_installer_win.cc. (Closed)
Patch Set: clarify comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/sw_reporter_installer_win.cc
diff --git a/chrome/browser/component_updater/sw_reporter_installer_win.cc b/chrome/browser/component_updater/sw_reporter_installer_win.cc
index 34241417ab0b2c0d977c7f03b49d22566ba75fda..670e72da171a43efbab626611e4ac39180bc03f6 100644
--- a/chrome/browser/component_updater/sw_reporter_installer_win.cc
+++ b/chrome/browser/component_updater/sw_reporter_installer_win.cc
@@ -136,13 +136,15 @@ void RunSwReportersAfterStartup(
FROM_HERE, base::ThreadTaskRunnerHandle::Get(),
base::Bind(&safe_browsing::RunSwReporters, invocations, version,
base::ThreadTaskRunnerHandle::Get(),
- // Runs LaunchAndWaitForExit() (srt_fetcher_win.cc).
+ // Runs LaunchAndWaitForExit() which creates (MayBlock()) and
+ // joins (WithSyncPrimitives()) a process.
base::CreateTaskRunnerWithTraits(
base::TaskTraits()
.WithShutdownBehavior(
base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN)
.WithPriority(base::TaskPriority::BACKGROUND)
- .WithWait())));
+ .MayBlock()
+ .WithSyncPrimitives())));
}
// Ensures |str| contains only alphanumeric characters and characters from
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698