Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2596763002: Fix username absent right after signing in in main Settings. (Closed)

Created:
4 years ago by bzanotti
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix username absent right after signing in in main Settings. BUG=676237 Committed: https://crrev.com/328a1cde4bfd641b8192789d124ab535c47b2d46 Cr-Commit-Position: refs/heads/master@{#441621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ios/chrome/browser/ui/settings/settings_collection_view_controller.mm View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bzanotti
Please take a look (please CQ as well if it looks good to you since ...
4 years ago (2016-12-21 05:42:57 UTC) #2
bzanotti
Ping.
3 years, 11 months ago (2017-01-05 10:35:42 UTC) #3
lpromero
lgtm
3 years, 11 months ago (2017-01-05 10:40:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596763002/1
3 years, 11 months ago (2017-01-05 10:41:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-05 10:51:23 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 10:54:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/328a1cde4bfd641b8192789d124ab535c47b2d46
Cr-Commit-Position: refs/heads/master@{#441621}

Powered by Google App Engine
This is Rietveld 408576698