Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2955)

Unified Diff: ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

Issue 2596763002: Fix username absent right after signing in in main Settings. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm b/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
index f8eacb202f45f22e9e30f260652be450d8b8e209..739c432729490804ff4fe5cb8df38bc50c167459 100644
--- a/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
@@ -895,10 +895,10 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
return;
}
identityAccountItem.image = [self userAccountImage];
+ identityAccountItem.text = [_identity userFullName];
SyncSetupService* syncSetupService =
SyncSetupServiceFactory::GetForBrowserState(_mainBrowserState);
-
if (!syncSetupService->HasFinishedInitialSetup()) {
identityAccountItem.detailText =
l10n_util::GetNSString(IDS_IOS_SYNC_SETUP_IN_PROGRESS);
@@ -908,7 +908,6 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,
identityAccountItem.shouldDisplayError =
!ios_internal::sync::IsTransientSyncError(
syncSetupService->GetSyncServiceState());
- identityAccountItem.text = [_identity userFullName];
if (identityAccountItem.shouldDisplayError) {
identityAccountItem.detailText =
ios_internal::sync::GetSyncErrorDescriptionForBrowserState(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698