Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2596443005: Replace DOMWindowProperty in Navigator supplements with ContextClient (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, toyoshim+midi_chromium.org, mvanouwerkerk+watch_chromium.org, mlamouri+watch-blink_chromium.org, tzik, timvolodine, nhiroki, haraken, feature-vr-reviews_chromium.org, jkarlin+watch_chromium.org, blink-reviews, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace DOMWindowProperty in Navigator supplements with ContextClient This is a preparation for deprecating DOMWindowProperty. BUG=610176 Committed: https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6 Cr-Commit-Position: refs/heads/master@{#440093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -41 lines) Patch
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NavigatorNetworkInformation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NavigatorNetworkInformation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/NavigatorPlugins.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/NavigatorPlugins.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
4 years ago (2016-12-21 12:13:30 UTC) #2
sof
lgtm
4 years ago (2016-12-21 12:28:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596443005/1
4 years ago (2016-12-21 12:35:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 14:26:45 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 14:29:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6
Cr-Commit-Position: refs/heads/master@{#440093}

Powered by Google App Engine
This is Rietveld 408576698