third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h - Issue 2596443005: Replace DOMWindowProperty in Navigator supplements with ContextClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h

Issue 2596443005: Replace DOMWindowProperty in Navigator supplements with ContextClient (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp ('k') | third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h

diff --git a/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h b/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h

index 65516cd396705bf96ffae1ddaa0f43f4fa8cbb31..e5668d1cf9825b5ffe2fd22224875aee29c7b620 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h

+++ b/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h

@@ -5,7 +5,7 @@

#ifndef NavigatorCredentials_h

#define NavigatorCredentials_h

-#include "core/frame/DOMWindowProperty.h"

+#include "core/dom/ContextLifecycleObserver.h"

#include "core/frame/Navigator.h"

#include "platform/Supplementable.h"

#include "platform/heap/Handle.h"

@@ -18,7 +18,7 @@ class Navigator;

class NavigatorCredentials final

: public GarbageCollected<NavigatorCredentials>,

public Supplement<Navigator>,

- public DOMWindowProperty {

+ public ContextClient {

USING_GARBAGE_COLLECTED_MIXIN(NavigatorCredentials);

public: