Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 2596203002: Return sizes' default effective size as float (Closed)

Created:
4 years ago by Yoav Weiss
Modified:
4 years ago
Reviewers:
rune
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, mattcary
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return sizes' default effective size as float As pointed out in the issue, the default effective size is converted from double to unsigned to float for no good reason. his CL makes sure there's a single explicit (clamped) conversion from double to float. BUG=675204 Committed: https://crrev.com/12e5afd8b8cca061b9a11fdaccb4bd198cb772b5 Cr-Commit-Position: refs/heads/master@{#440404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/parser/SizesAttributeParser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesAttributeParserTest.cpp View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Yoav Weiss
4 years ago (2016-12-22 10:47:31 UTC) #4
rune
lgtm
4 years ago (2016-12-22 11:31:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596203002/1
4 years ago (2016-12-22 13:37:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 13:41:53 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 13:43:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12e5afd8b8cca061b9a11fdaccb4bd198cb772b5
Cr-Commit-Position: refs/heads/master@{#440404}

Powered by Google App Engine
This is Rietveld 408576698