third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp - Issue 2596203002: Return sizes' default effective size as float

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp

Issue 2596203002: Return sizes' default effective size as float (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp b/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp

index 375a0cc9918b2ded2399b7f64da88600c60312d3..3709e4a2028f44986229e34fc2f2a98a5c3fc5dc 100644

--- a/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp

@@ -97,9 +97,9 @@ float SizesAttributeParser::effectiveSize() {

return effectiveSizeDefaultValue();

}

-unsigned SizesAttributeParser::effectiveSizeDefaultValue() {

+float SizesAttributeParser::effectiveSizeDefaultValue() {

// Returning the equivalent of "100vw"

- return m_mediaValues->viewportWidth();

+ return clampTo<float>(m_mediaValues->viewportWidth());

}

} // namespace blink