Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2596083002: MD Settings: Defer opening Import Dialog dialog to prevent UI flicker (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Defer opening Import Dialog dialog to prevent UI flicker This defers opening the dialog until the browser profiles data is populated to avoid UI flicker. BUG=675381 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9dd55db3211dcdd9fd6d8e77a3c12ee8cf041938 Cr-Commit-Position: refs/heads/master@{#440430}

Patch Set 1 #

Patch Set 2 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/settings/people_page/import_data_dialog.js View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/import_data_dialog_test.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (15 generated)
tommycli
dpapad: PTAL. The linux performance looked okay on my machine. Let me know what you ...
4 years ago (2016-12-21 23:52:38 UTC) #9
dpapad
lgtm
4 years ago (2016-12-22 00:48:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596083002/40001
4 years ago (2016-12-22 15:50:38 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-22 15:54:49 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-22 15:59:31 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9dd55db3211dcdd9fd6d8e77a3c12ee8cf041938
Cr-Commit-Position: refs/heads/master@{#440430}

Powered by Google App Engine
This is Rietveld 408576698