chrome/browser/resources/settings/people_page/import_data_dialog.js - Issue 2596083002: MD Settings: Defer opening Import Dialog dialog to prevent UI flicker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/import_data_dialog.js

Issue 2596083002: MD Settings: Defer opening Import Dialog dialog to prevent UI flicker (Closed)

Patch Set: Update test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/people_page/import_data_dialog.js

diff --git a/chrome/browser/resources/settings/people_page/import_data_dialog.js b/chrome/browser/resources/settings/people_page/import_data_dialog.js

index e035c281577d645275687921dfceb0bb6e3d6eec..058a27f7858cc41a95dd9eaf68b715e7f2134525 100644

--- a/chrome/browser/resources/settings/people_page/import_data_dialog.js

+++ b/chrome/browser/resources/settings/people_page/import_data_dialog.js

@@ -58,6 +58,10 @@ Polymer({

function(data) {

this.browserProfiles_ = data;

this.selected_ = this.browserProfiles_[0];

+ // Show the dialog only after the browser profiles data is populated

+ // to avoid UI flicker.

+ this.$.dialog.showModal();

}.bind(this));

this.addWebUIListener(

@@ -68,8 +72,6 @@ Polymer({

if (this.hasImportStatus_(settings.ImportDataStatus.FAILED))

this.closeDialog_();

}.bind(this));

- this.$.dialog.showModal();

/** @private */

« no previous file with comments | « no previous file | chrome/test/data/webui/settings/import_data_dialog_test.js » ('j') | no next file with comments »