Extract diff_text function out of the Port class.

Extract diff_text function out of the Port class.

This is a refactoring change related to, but separate from,
the issue of replacing wdiff and PrettyPatch.rb with a Python
diff module (http://crbug.com/672651), and a follow-up to
adding html_diff.py (http://crrev.com/2580143002).

Reason: The functionality of getting a text diff shouldn't be platform
dependent, so it doesn't really seem to belong in the Port class. (It
seems more similar to the html_diff module in webkitpy/common/.)

Review-Url: https://codereview.chromium.org/2595983002
Cr-Commit-Position: refs/heads/master@{#443067}
Committed: https://chromium.googlesource.com/chromium/src/+/938778c92da3d97c66a4fa16c0d79a019c0c40da

[qyearsley, 2016-12-21 19:52:42]

Description was changed from

==========
Extract diff_text function out of the Port class.

Reason: The functionality of getting a text diff shouldn't be platform
dependent, so ideally it doesn't really belong in the Port class.
The Port class is large and contains some functionality that's not
platform-specific; ideally such functionality could be put elsewhere.

After adding a HTML diff utility to webkitpy/common/, it seems reasonable
to also put the text diff function in the same place.

This is related to http://crbug.com/672651, but is separate.
==========

to

==========
Extract diff_text function out of the Port class.

This is a refactoring change related to, but separate from,
the issue of replacing wdiff and PrettyPatch.rb with a Python
diff module (http://crbug.com/672651), and a follow-up to
adding html_diff.py (http://crrev.com/2580143002).

Reason: The functionality of getting a text diff shouldn't be platform
dependent, so it doesn't really seem to belong in the Port class. (It
seems more similar to the html_diff module in webkitpy/common/.)
==========

[qyearsley, 2016-12-21 19:52:42]

qyearsley@chromium.org changed reviewers:
+ estaab@chromium.org

[qyearsley, 2016-12-21 19:53:52]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 19:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:29:12]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-12-28 02:48:51]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 02:49:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 04:06:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 04:06:23]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-01-05 21:25:27]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 21:26:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 22:33:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:33:45]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-01-10 23:48:41]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 23:49:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-01-10 23:58:50]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:11:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:11:10]

Dry run: This issue passed the CQ dry run.

[estaab, 2017-01-11 08:19:23]

Sorry for being silent on this. Will Jeff be able to review it or should I still
take it?

[qyearsley, 2017-01-11 17:24:43]

On 2017/01/11 at 08:19:23, estaab wrote:
> Sorry for being silent on this. Will Jeff be able to review it or should I
still take it?

No problem; this is a non-urgent refactoring change.

Jeff is able to review it, although I always appreciate feedback :-)

As noted in the description, the reason for this change was just that this code
is not platform-dependent, and in general the purpose of the Port classes is to
contain platform-dependent code.

[jeffcarp, 2017-01-11 21:46:49]

lgtm

https://codereview.chromium.org/2595983002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/common/unified_diff_unittest.py
(right):

https://codereview.chromium.org/2595983002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/common/unified_diff_unittest.py:20:
'--- exp.txt\n+++ act.txt\n@@ -1,3 +1,5 @@\n Hello\n \n-World\n\\ No newline at
end of file\n+World\n+\n+\n')
This indentation format looks inconsistent to line 40

[qyearsley, 2017-01-11 22:24:02]

https://codereview.chromium.org/2595983002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/common/unified_diff_unittest.py
(right):

https://codereview.chromium.org/2595983002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/common/unified_diff_unittest.py:20:
'--- exp.txt\n+++ act.txt\n@@ -1,3 +1,5 @@\n Hello\n \n-World\n\\ No newline at
end of file\n+World\n+\n+\n')
On 2017/01/11 at 21:46:49, jeffcarp wrote:
> This indentation format looks inconsistent to line 40

Hm, yeah. In both cases there's a 4-space indent after a line break before
function arguments, except since we're allowing long lines up to 132 spaces,
there's no need for the line break on line 39/40. Changed.

[qyearsley, 2017-01-11 22:24:06]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-01-11 22:24:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2595983002/#ps40001
(title: "Change indentation")

[commit-bot: I haz the power, 2017-01-11 22:25:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 00:09:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484173446567390,
"parent_rev": "dfc7302588449730604019c9ca057bcbf83544d0", "commit_rev":
"938778c92da3d97c66a4fa16c0d79a019c0c40da"}

[commit-bot: I haz the power, 2017-01-12 00:10:20]

Description was changed from

==========
Extract diff_text function out of the Port class.

This is a refactoring change related to, but separate from,
the issue of replacing wdiff and PrettyPatch.rb with a Python
diff module (http://crbug.com/672651), and a follow-up to
adding html_diff.py (http://crrev.com/2580143002).

Reason: The functionality of getting a text diff shouldn't be platform
dependent, so it doesn't really seem to belong in the Port class. (It
seems more similar to the html_diff module in webkitpy/common/.)
==========

to

==========
Extract diff_text function out of the Port class.

This is a refactoring change related to, but separate from,
the issue of replacing wdiff and PrettyPatch.rb with a Python
diff module (http://crbug.com/672651), and a follow-up to
adding html_diff.py (http://crrev.com/2580143002).

Reason: The functionality of getting a text diff shouldn't be platform
dependent, so it doesn't really seem to belong in the Port class. (It
seems more similar to the html_diff module in webkitpy/common/.)

Review-Url: https://codereview.chromium.org/2595983002
Cr-Commit-Position: refs/heads/master@{#443067}
Committed:
https://chromium.googlesource.com/chromium/src/+/938778c92da3d97c66a4fa16c0d7...
==========

[commit-bot: I haz the power, 2017-01-12 00:10:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/938778c92da3d97c66a4fa16c0d7...