third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py - Issue 2595983002: Extract diff_text function out of the Port class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

Issue 2595983002: Extract diff_text function out of the Port class. (Closed)

Patch Set: Change indentation Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/unified_diff_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

index fc70eec5f2f3f53fe7d4d5c937ef69eb0bb1873f..838c9ab4b98236c360c1490b7fea029cb8c4ea00 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

@@ -30,6 +30,7 @@

import logging

from webkitpy.common.html_diff import html_diff

+from webkitpy.common.unified_diff import unified_diff

from webkitpy.layout_tests.controllers import repaint_overlay

from webkitpy.layout_tests.models import test_failures

@@ -204,7 +205,7 @@ class TestResultWriter(object):

file_type = '.txt'

actual_filename = self.output_filename(self.FILENAME_SUFFIX_ACTUAL + file_type)

expected_filename = self.output_filename(self.FILENAME_SUFFIX_EXPECTED + file_type)

- diff = self._port.diff_text(expected_text, actual_text, expected_filename, actual_filename)

+ diff = unified_diff(expected_text, actual_text, expected_filename, actual_filename)

diff_filename = self.output_filename(self.FILENAME_SUFFIX_DIFF + file_type)

self._write_file(diff_filename, diff)