[NTP::RecentTabs] Do not fetch all pages when not a recent tab is added.

[NTP::RecentTabs] Do not fetch all pages when not a recent tab is added.

Currently, all offline pages are fetched when a new offline page is
added (even it if is not a recent tab). However, there is no sense to
refetch if there is no new recent tabs.

This CL changes the logic to fetch only when the added offline page is a
recent tab.

BUG=672433
Committed: https://crrev.com/ad80f041ddc7bff1360592184661fd51bdf414e9
Cr-Commit-Position: refs/heads/master@{#440096}

[vitaliii, 2016-12-21 11:22:57]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 11:23:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vitaliii, 2016-12-21 11:24:35]

vitaliii@chromium.org changed reviewers:
+ jkrcal@chromium.org

[vitaliii, 2016-12-21 11:24:35]

[low priority]

Hi jkrcal@,

PTAL.

[commit-bot: I haz the power, 2016-12-21 12:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 12:07:20]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2016-12-21 12:08:29]

lgtm

https://codereview.chromium.org/2595873002/diff/1/components/ntp_snippets/off...
File components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
(right):

https://codereview.chromium.org/2595873002/diff/1/components/ntp_snippets/off...
components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc:72:
bool IsClientIdForOfflinePageRecentTab(
nit: hard to parse (with the standard coding convention to omit articles ;)

What about just IsRecentTab?
 (maybe with renaming the second arg to offline_page_client_id)

https://codereview.chromium.org/2595873002/diff/1/components/ntp_snippets/off...
components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc:221: if
(IsClientIdForOfflinePageRecentTab(model->GetPolicyController(),
nit: 

If easy to set up, can you add a unit-test to check that it is not fetched when
it is a non-Recent-Tab offline page is added?

If not easy to do, just skip it. This is not an important functionality.

[vitaliii, 2016-12-21 13:39:07]

I addressed your nits, no need to look.

https://codereview.chromium.org/2595873002/diff/1/components/ntp_snippets/off...
File components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
(right):

https://codereview.chromium.org/2595873002/diff/1/components/ntp_snippets/off...
components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc:72:
bool IsClientIdForOfflinePageRecentTab(
On 2016/12/21 12:08:29, jkrcal wrote:
> nit: hard to parse (with the standard coding convention to omit articles ;)
> 
> What about just IsRecentTab?
>  (maybe with renaming the second arg to offline_page_client_id)

Done.

IsRecentTab with OfflinePageItem as the second argument.

https://codereview.chromium.org/2595873002/diff/1/components/ntp_snippets/off...
components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc:221: if
(IsClientIdForOfflinePageRecentTab(model->GetPolicyController(),
On 2016/12/21 12:08:29, jkrcal wrote:
> nit: 
> 
> If easy to set up, can you add a unit-test to check that it is not fetched
when
> it is a non-Recent-Tab offline page is added?
> 
> If not easy to do, just skip it. This is not an important functionality.

Done.

[vitaliii, 2016-12-21 13:39:15]

The CQ bit was checked by vitaliii@chromium.org

[vitaliii, 2016-12-21 13:39:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jkrcal@chromium.org
Link to the patchset: https://codereview.chromium.org/2595873002/#ps20001
(title: "jkrcal@ nits.")

[commit-bot: I haz the power, 2016-12-21 13:39:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 14:41:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482327555013400,
"parent_rev": "9b4c7d17eb325ae43f4857aaf20ebcdea0928ddc", "commit_rev":
"32ad3aac61bb2ca81f30ac274b839d8449f3c6e1"}

[commit-bot: I haz the power, 2016-12-21 14:41:42]

Description was changed from

==========
[NTP::RecentTabs] Do not fetch all pages when not a recent tab is added.

Currently, all offline pages are fetched when a new offline page is
added (even it if is not a recent tab). However, there is no sense to
refetch if there is no new recent tabs.

This CL changes the logic to fetch only when the added offline page is a
recent tab.

BUG=672433
==========

to

==========
[NTP::RecentTabs] Do not fetch all pages when not a recent tab is added.

Currently, all offline pages are fetched when a new offline page is
added (even it if is not a recent tab). However, there is no sense to
refetch if there is no new recent tabs.

This CL changes the logic to fetch only when the added offline page is a
recent tab.

BUG=672433

Review-Url: https://codereview.chromium.org/2595873002
==========

[commit-bot: I haz the power, 2016-12-21 14:41:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 14:44:06]

Description was changed from

==========
[NTP::RecentTabs] Do not fetch all pages when not a recent tab is added.

Currently, all offline pages are fetched when a new offline page is
added (even it if is not a recent tab). However, there is no sense to
refetch if there is no new recent tabs.

This CL changes the logic to fetch only when the added offline page is a
recent tab.

BUG=672433

Review-Url: https://codereview.chromium.org/2595873002
==========

to

==========
[NTP::RecentTabs] Do not fetch all pages when not a recent tab is added.

Currently, all offline pages are fetched when a new offline page is
added (even it if is not a recent tab). However, there is no sense to
refetch if there is no new recent tabs.

This CL changes the logic to fetch only when the added offline page is a
recent tab.

BUG=672433

Committed: https://crrev.com/ad80f041ddc7bff1360592184661fd51bdf414e9
Cr-Commit-Position: refs/heads/master@{#440096}
==========

[commit-bot: I haz the power, 2016-12-21 14:44:07]

Patchset 2 (id:??) landed as
https://crrev.com/ad80f041ddc7bff1360592184661fd51bdf414e9
Cr-Commit-Position: refs/heads/master@{#440096}