Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

Issue 2595873002: [NTP::RecentTabs] Do not fetch all pages when not a recent tab is added. (Closed)
Patch Set: jkrcal@ nits. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
diff --git a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
index 6d689dbc17a334ba51b390aaf851538276813dc2..7ff4cc7c6794ee334317c51445be2dbc06c64653 100644
--- a/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
+++ b/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
@@ -69,6 +69,12 @@ std::unique_ptr<OfflinePageModelQuery> BuildRecentTabsQuery(
return builder.Build(model->GetPolicyController());
}
+bool IsRecentTab(offline_pages::ClientPolicyController* policy_controller,
+ const OfflinePageItem& offline_page) {
+ return policy_controller->IsShownAsRecentlyVisitedSite(
+ offline_page.client_id.name_space);
+}
+
} // namespace
RecentTabSuggestionsProvider::RecentTabSuggestionsProvider(
@@ -212,7 +218,9 @@ void RecentTabSuggestionsProvider::OfflinePageAdded(
offline_pages::OfflinePageModel* model,
const offline_pages::OfflinePageItem& added_page) {
DCHECK_EQ(offline_page_model_, model);
- FetchRecentTabs();
+ if (IsRecentTab(model->GetPolicyController(), added_page)) {
+ FetchRecentTabs();
+ }
}
void RecentTabSuggestionsProvider::
« no previous file with comments | « no previous file | components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698