Load Market App for Fallback URLs.

Load Market App for Fallback URLs.

When handling a fallback URL for an app because the app is not
installed, if the app developer specified Play Store URL as a fallback
URL, then take the user to the Play Store App instead of loading the URL
in the browser.

BUG=638672
Committed: https://crrev.com/41b288d33cad4776bc5f09ee435703a214449aaf
Cr-Commit-Position: refs/heads/master@{#440297}

[Maria, 2016-12-21 01:16:14]

mariakhomenko@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Maria, 2016-12-21 18:43:27]

https://codereview.chromium.org/2595773002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/2595773002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:580:
uri.getQueryParameter(EXTRA_MARKET_REFERRER));
So here I am telling the devs to encode their market referrer id in the URL as
market_referrer=xyz. There's an analogous extra for intent:// URLs to apps.
However the market:// URL uses just referrer=xyz. I can't decide whether the
http URL for fallback should have market_referrer or just referrer query param.
Thoughts?

[Maria, 2016-12-21 21:59:22]

https://codereview.chromium.org/2595773002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/2595773002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:580:
uri.getQueryParameter(EXTRA_MARKET_REFERRER));
On 2016/12/21 18:43:27, Maria wrote:
> So here I am telling the devs to encode their market referrer id in the URL as
> market_referrer=xyz. There's an analogous extra for intent:// URLs to apps.
> However the market:// URL uses just referrer=xyz. I can't decide whether the
> http URL for fallback should have market_referrer or just referrer query
param.
> Thoughts?

Okay, I found references to referrer already being used on play http URLs, so I
am switching to that. PTAL.

[gone, 2016-12-21 22:09:38]

lgtm

[Maria, 2016-12-21 22:30:21]

The CQ bit was checked by mariakhomenko@chromium.org

[Maria, 2016-12-21 22:30:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2595773002/#ps40001
(title: "Fix test")

[commit-bot: I haz the power, 2016-12-21 22:30:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 00:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 00:03:09]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Maria, 2016-12-22 00:37:04]

The CQ bit was checked by mariakhomenko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 00:37:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Maria, 2016-12-22 01:08:09]

The CQ bit was unchecked by mariakhomenko@chromium.org

[Maria, 2016-12-22 01:08:18]

The CQ bit was checked by mariakhomenko@chromium.org

[Maria, 2016-12-22 01:08:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2595773002/#ps60001
(title: "Move main frame check back.")

[commit-bot: I haz the power, 2016-12-22 01:08:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:23:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482368898946810,
"parent_rev": "d74e8ff0f2cfde4874c2e2f583f23087e1b203d5", "commit_rev":
"98e387633cd723a0eed1b6517e05df17e84f30e6"}

[commit-bot: I haz the power, 2016-12-22 01:24:07]

Description was changed from

==========
Load Market App for Fallback URLs.

When handling a fallback URL for an app because the app is not
installed, if the app developer specified Play Store URL as a fallback
URL, then take the user to the Play Store App instead of loading the URL
in the browser.

BUG=638672
==========

to

==========
Load Market App for Fallback URLs.

When handling a fallback URL for an app because the app is not
installed, if the app developer specified Play Store URL as a fallback
URL, then take the user to the Play Store App instead of loading the URL
in the browser.

BUG=638672

Review-Url: https://codereview.chromium.org/2595773002
==========

[commit-bot: I haz the power, 2016-12-22 01:24:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-22 01:27:12]

Description was changed from

==========
Load Market App for Fallback URLs.

When handling a fallback URL for an app because the app is not
installed, if the app developer specified Play Store URL as a fallback
URL, then take the user to the Play Store App instead of loading the URL
in the browser.

BUG=638672

Review-Url: https://codereview.chromium.org/2595773002
==========

to

==========
Load Market App for Fallback URLs.

When handling a fallback URL for an app because the app is not
installed, if the app developer specified Play Store URL as a fallback
URL, then take the user to the Play Store App instead of loading the URL
in the browser.

BUG=638672

Committed: https://crrev.com/41b288d33cad4776bc5f09ee435703a214449aaf
Cr-Commit-Position: refs/heads/master@{#440297}
==========

[commit-bot: I haz the power, 2016-12-22 01:27:13]

Patchset 4 (id:??) landed as
https://crrev.com/41b288d33cad4776bc5f09ee435703a214449aaf
Cr-Commit-Position: refs/heads/master@{#440297}