Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4687)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 2595773002: Load Market App for Fallback URLs. (Closed)
Patch Set: Move main frame check back. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index 07d89145a1469c243da13dcca9053c12e9c826a8..e33d87a99c1c61e3965e18f065782d2cec57f345 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -682,6 +682,38 @@ public class ExternalNavigationHandlerTest extends NativeLibraryTestBase {
}
@SmallTest
+ public void testFallbackUrl_FallbackToMarketApp() {
+ mDelegate.setCanResolveActivity(false);
+
+ String intent = "intent:///name/nm0000158#Intent;scheme=imdb;package=com.imdb.mobile;"
+ + "S." + ExternalNavigationHandler.EXTRA_BROWSER_FALLBACK_URL + "="
+ + "https://play.google.com/store/apps/details?id=com.imdb.mobile"
+ + "&referrer=mypage;end";
+ checkUrl(intent)
+ .expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
+ START_OTHER_ACTIVITY);
+
+ assertEquals("market://details?id=com.imdb.mobile&referrer=mypage",
+ mDelegate.startActivityIntent.getDataString());
+
+ String intentNoRef = "intent:///name/nm0000158#Intent;scheme=imdb;package=com.imdb.mobile;"
+ + "S." + ExternalNavigationHandler.EXTRA_BROWSER_FALLBACK_URL + "="
+ + "https://play.google.com/store/apps/details?id=com.imdb.mobile;end";
+ checkUrl(intentNoRef)
+ .expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
+ START_OTHER_ACTIVITY);
+
+ assertEquals("market://details?id=com.imdb.mobile&referrer=test",
+ mDelegate.startActivityIntent.getDataString());
+
+ String intentBadUrl = "intent:///name/nm0000158#Intent;scheme=imdb;package=com.imdb.mobile;"
+ + "S." + ExternalNavigationHandler.EXTRA_BROWSER_FALLBACK_URL + "="
+ + "https://play.google.com/store/search?q=pub:imdb;end";
+ checkUrl(intentBadUrl)
+ .expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_CLOBBERING_TAB, IGNORE);
+ }
+
+ @SmallTest
public void testFallbackUrl_IntentResolutionFailsWithoutPackageName() {
// IMDB app isn't installed.
mDelegate.setCanResolveActivity(false);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698