Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 2595413003: Revert of [debugger] deprecate v8::Debug:GetDebugContext. (Closed)

Created:
3 years, 12 months ago by Yang
Modified:
3 years, 12 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] deprecate v8::Debug:GetDebugContext. (patchset #2 id:20001 of https://codereview.chromium.org/2589203002/ ) Reason for revert: crbug/676749 Original issue's description: > [debugger] deprecate v8::Debug:GetDebugContext. > > R=jgruber@chromium.org > BUG=v8:5530 > > Review-Url: https://codereview.chromium.org/2589203002 > Cr-Commit-Position: refs/heads/master@{#41911} > Committed: https://chromium.googlesource.com/v8/v8/+/381082168d37d4f2794360ae31dc078f2a350113 TBR=jgruber@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5530, chromium:676749 Review-Url: https://codereview.chromium.org/2595413003 Cr-Commit-Position: refs/heads/master@{#41935} Committed: https://chromium.googlesource.com/v8/v8/+/f85678159df2963b7fd49588d7af22096c4615b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M include/v8-debug.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Yang
Created Revert of [debugger] deprecate v8::Debug:GetDebugContext.
3 years, 12 months ago (2016-12-23 08:42:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595413003/1
3 years, 12 months ago (2016-12-23 08:42:27 UTC) #3
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 09:15:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f85678159df2963b7fd49588d7af22096c4...

Powered by Google App Engine
This is Rietveld 408576698