Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2589203002: [debugger] deprecate v8::Debug:GetDebugContext. (Closed)

Created:
4 years ago by Yang
Modified:
3 years, 11 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] deprecate v8::Debug:GetDebugContext. R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2589203002 Cr-Original-Commit-Position: refs/heads/master@{#41911} Committed: https://chromium.googlesource.com/v8/v8/+/381082168d37d4f2794360ae31dc078f2a350113 Review-Url: https://codereview.chromium.org/2589203002 Cr-Commit-Position: refs/heads/master@{#42220} Committed: https://chromium.googlesource.com/v8/v8/+/a8cfc2f5e49a40f134ac342ae0cf629df494e6ce

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : remove deprecated use #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -27 lines) Patch
M include/v8-debug.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/api.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/inspector/v8-debugger.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
Yang
4 years ago (2016-12-20 12:25:04 UTC) #1
jgruber
lgtm
4 years ago (2016-12-20 12:26:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589203002/1
4 years ago (2016-12-20 12:27:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14558)
4 years ago (2016-12-20 12:32:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589203002/20001
4 years ago (2016-12-20 13:05:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/30096)
4 years ago (2016-12-20 13:27:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589203002/20001
4 years ago (2016-12-22 06:34:09 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/381082168d37d4f2794360ae31dc078f2a350113
4 years ago (2016-12-22 07:04:08 UTC) #16
Yang
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2595413003/ by yangguo@chromium.org. ...
3 years, 12 months ago (2016-12-23 08:42:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589203002/20001
3 years, 11 months ago (2017-01-09 10:46:24 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/15159)
3 years, 11 months ago (2017-01-09 10:51:35 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589203002/40001
3 years, 11 months ago (2017-01-11 11:30:47 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 12:00:01 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a8cfc2f5e49a40f134ac342ae0cf629df49...

Powered by Google App Engine
This is Rietveld 408576698