Bluetooth: mac: Working on macOS descriptor implementation.

Bluetooth: mac: Working on macOS descriptor implementation.

Descriptors are discovered. Read and write are still not implemented yet. Once a characteristic is discovered, the descriptor request is send. After receive the response the characteristic is set as been discovered.
Unit tests are been enabled for descriptor discovery.

BUG=624017
Review-Url: https://codereview.chromium.org/2595373003
Cr-Commit-Position: refs/heads/master@{#442440}
Committed: https://chromium.googlesource.com/chromium/src/+/9bb8cf24e8585342e57493dea8acc31772f48438

[jlebel, 2017-01-07 13:39:37]

Patchset #2 (id:20001) has been deleted

[jlebel, 2017-01-07 13:42:12]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 13:42:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2017-01-07 14:27:28]

Patchset #2 (id:40001) has been deleted

[jlebel, 2017-01-07 16:48:25]

Description was changed from

==========
Bluetooth: mac: Working on macOS descriptor implementation.


BUG=
==========

to

==========
Bluetooth: mac: Working on macOS descriptor implementation.

Descriptors are discovered. Read and write are still not implemented yet. Once a
characteristic is discovered, the descriptor request is send. After receive the
response the characteristic is set as been discovered.
Unit tests are been enabled for descriptor discovery.

BUG=624017
==========

[jlebel, 2017-01-07 16:50:17]

jlebel@chromium.org changed reviewers:
+ fbeaufort@chromium.org, scheib@chromium.org

[jlebel, 2017-01-07 16:50:18]

Hello Vincent,

Can you review this about about implementing descriptor discovery?

Thanks,

[jlebel, 2017-01-07 16:51:01]

Patchset #2 (id:60001) has been deleted

[jlebel, 2017-01-07 16:55:57]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 16:56:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2017-01-07 17:23:21]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 17:23:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 19:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 19:14:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jlebel, 2017-01-08 10:07:17]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-08 10:07:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2017-01-08 10:07:29]

Patchset #3 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-01-08 12:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-08 12:26:49]

Dry run: This issue passed the CQ dry run.

[scheib, 2017-01-09 21:07:37]

LGTM, small requests:

https://codereview.chromium.org/2595373003/diff/120001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_low_energy_device_mac.h (right):

https://codereview.chromium.org/2595373003/diff/120001/device/bluetooth/bluet...
device/bluetooth/bluetooth_low_energy_device_mac.h:111: void
SendNotificationIfComplete();
Perhaps naming such as SendNotificationIfDiscoveryComplete

https://codereview.chromium.org/2595373003/diff/120001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_remote_gatt_descriptor_mac.h (right):

https://codereview.chromium.org/2595373003/diff/120001/device/bluetooth/bluet...
device/bluetooth/bluetooth_remote_gatt_descriptor_mac.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
2017

[jlebel, 2017-01-09 22:58:32]

Fixed.

Thanks,

https://codereview.chromium.org/2595373003/diff/120001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_low_energy_device_mac.h (right):

https://codereview.chromium.org/2595373003/diff/120001/device/bluetooth/bluet...
device/bluetooth/bluetooth_low_energy_device_mac.h:111: void
SendNotificationIfComplete();
On 2017/01/09 21:07:37, scheib wrote:
> Perhaps naming such as SendNotificationIfDiscoveryComplete

Done.

https://codereview.chromium.org/2595373003/diff/120001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_remote_gatt_descriptor_mac.h (right):

https://codereview.chromium.org/2595373003/diff/120001/device/bluetooth/bluet...
device/bluetooth/bluetooth_remote_gatt_descriptor_mac.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/01/09 21:07:37, scheib wrote:
> 2017

Done.

[jlebel, 2017-01-09 22:58:40]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2017-01-09 22:58:41]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2595373003/#ps140001
(title: "Fixes")

[commit-bot: I haz the power, 2017-01-09 22:59:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 01:29:06]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484002720723400,
"parent_rev": "352dc2ea1f8f043345e4eea1b298ff7292bb882c", "commit_rev":
"9bb8cf24e8585342e57493dea8acc31772f48438"}

[commit-bot: I haz the power, 2017-01-10 01:29:36]

Description was changed from

==========
Bluetooth: mac: Working on macOS descriptor implementation.

Descriptors are discovered. Read and write are still not implemented yet. Once a
characteristic is discovered, the descriptor request is send. After receive the
response the characteristic is set as been discovered.
Unit tests are been enabled for descriptor discovery.

BUG=624017
==========

to

==========
Bluetooth: mac: Working on macOS descriptor implementation.

Descriptors are discovered. Read and write are still not implemented yet. Once a
characteristic is discovered, the descriptor request is send. After receive the
response the characteristic is set as been discovered.
Unit tests are been enabled for descriptor discovery.

BUG=624017

Review-Url: https://codereview.chromium.org/2595373003
Cr-Commit-Position: refs/heads/master@{#442440}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bb8cf24e8585342e57493dea8ac...
==========

[commit-bot: I haz the power, 2017-01-10 01:29:39]

Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/9bb8cf24e8585342e57493dea8ac...