Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc

Issue 2595373003: Bluetooth: mac: Working on macOS descriptor implementation. (Closed)
Patch Set: Fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
index 4adae36c00468164e96d32be08989d6c9a098805..0b09275d3f8ca3683ec07e9250492f7b23ad5288 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
@@ -71,10 +71,6 @@ class BluetoothRemoteGattCharacteristicTest : public BluetoothTest {
}
ASSERT_NO_FATAL_FAILURE(FakeCharacteristicBoilerplate(properties));
-#if !defined(OS_MACOSX)
- // macOS: Not applicable. CoreBluetooth exposes -[CBPeripheral
- // setNotifyValue:forCharacteristic:] which handles all interactions with
- // the CCC descriptor.
size_t expected_descriptors_count = 0;
if (error != StartNotifySetupError::CONFIG_DESCRIPTOR_MISSING) {
SimulateGattDescriptor(
@@ -92,7 +88,6 @@ class BluetoothRemoteGattCharacteristicTest : public BluetoothTest {
}
ASSERT_EQ(expected_descriptors_count,
characteristic1_->GetDescriptors().size());
-#endif // !defined(OS_MACOSX)
if (error == StartNotifySetupError::SET_NOTIFY) {
SimulateGattCharacteristicSetNotifyWillFailSynchronouslyOnce(
« no previous file with comments | « device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm ('k') | device/bluetooth/bluetooth_remote_gatt_descriptor_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698