Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2595083002: Change ChooserContentView[Cocoa] class name to be DeviceChooserContentView[Cocoa] (Closed)

Created:
4 years ago by juncai
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, msramek+watch_chromium.org, tfarina, raymes+watch_chromium.org, mac-reviews_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ChooserContentView[Cocoa] class name to be DeviceChooserContentView[Cocoa] ChooserContentView[Cocoa] class name is too generic for //chrome/browser/ui/views/ and //chrome/browser/ui/cocoa directories. So change them to DeviceChooserContentView[Cocoa] to be more specific. BUG=651568 Committed: https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9 Cr-Commit-Position: refs/heads/master@{#441295}

Patch Set 1 : change ChooserContentView[Cocoa] class name to be DeviceChooserContentView[Cocoa] #

Patch Set 2 : updated comments #

Patch Set 3 : merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -2323 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/chooser_content_view_cocoa.h View 1 chunk +0 lines, -139 lines 0 comments Download
D chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm View 1 chunk +0 lines, -913 lines 0 comments Download
A + chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm View 4 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 6 chunks +25 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 10 chunks +18 lines, -17 lines 0 comments Download
D chrome/browser/ui/views/chooser_content_view.h View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/ui/views/chooser_content_view.cc View 1 2 1 chunk +0 lines, -327 lines 0 comments Download
D chrome/browser/ui/views/chooser_content_view_unittest.cc View 1 2 1 chunk +0 lines, -641 lines 0 comments Download
A + chrome/browser/ui/views/device_chooser_content_view.h View 4 chunks +19 lines, -21 lines 0 comments Download
A + chrome/browser/ui/views/device_chooser_content_view.cc View 1 2 12 chunks +28 lines, -27 lines 0 comments Download
A + chrome/browser/ui/views/device_chooser_content_view_unittest.cc View 1 2 23 chunks +42 lines, -40 lines 0 comments Download
M chrome/browser/ui/views/extensions/chooser_dialog_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/chooser_dialog_view.cc View 4 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/website_settings/chooser_bubble_delegate.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
juncai
Please take a look.
4 years ago (2016-12-21 19:03:33 UTC) #4
sky
LGTM
3 years, 11 months ago (2017-01-03 22:12:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595083002/40001
3 years, 11 months ago (2017-01-04 02:18:57 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-04 02:24:36 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 02:26:47 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9
Cr-Commit-Position: refs/heads/master@{#441295}

Powered by Google App Engine
This is Rietveld 408576698